Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446584 > unrolled thread

Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function call "mempool_destroy"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function  call "mempool_destroy" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-19 18:30 +0200
    Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function  call "mempool_destroy" David Rientjes <rientjes@google.com> - 2016-07-19 21:30 +0200

#1446584 — Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function call "mempool_destroy"

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 16 Nov 2015 08:20:36 +0100
> 
> The mempool_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/sh/kernel/dwarf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c
> index 9d209a0..e1d751a 100644
> --- a/arch/sh/kernel/dwarf.c
> +++ b/arch/sh/kernel/dwarf.c
> @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void)
>  	rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node)
>  		kfree(cie);
>  
> -	if (dwarf_reg_pool)
> -		mempool_destroy(dwarf_reg_pool);
> -	if (dwarf_frame_pool)
> -		mempool_destroy(dwarf_frame_pool);
> +	mempool_destroy(dwarf_reg_pool);
> +	mempool_destroy(dwarf_frame_pool);
>  	kmem_cache_destroy(dwarf_reg_cachep);
>  	kmem_cache_destroy(dwarf_frame_cachep);
>  }
> 

How do you think about to integrate this update suggestion
into another source code repository?

Regards,
Markus

[toc] | [next] | [standalone]

#1446681

On Tue, 19 Jul 2016, SF Markus Elfring wrote:

> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Mon, 16 Nov 2015 08:20:36 +0100
> > 
> > The mempool_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the calls is not needed.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  arch/sh/kernel/dwarf.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c
> > index 9d209a0..e1d751a 100644
> > --- a/arch/sh/kernel/dwarf.c
> > +++ b/arch/sh/kernel/dwarf.c
> > @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void)
> >  	rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node)
> >  		kfree(cie);
> >  
> > -	if (dwarf_reg_pool)
> > -		mempool_destroy(dwarf_reg_pool);
> > -	if (dwarf_frame_pool)
> > -		mempool_destroy(dwarf_frame_pool);
> > +	mempool_destroy(dwarf_reg_pool);
> > +	mempool_destroy(dwarf_frame_pool);
> >  	kmem_cache_destroy(dwarf_reg_cachep);
> >  	kmem_cache_destroy(dwarf_frame_cachep);
> >  }
> > 
> 
> How do you think about to integrate this update suggestion
> into another source code repository?
> 

Your patch is fine, but you may want to send it to the maintainers 
directly to merge.

$ ./scripts/get_maintainer.pl -f arch/sh/kernel/dwarf.c
Yoshinori Sato <ysato@users.sourceforge.jp> (maintainer:SUPERH)
Rich Felker <dalias@libc.org> (maintainer:SUPERH)
linux-sh@vger.kernel.org (open list:SUPERH)
linux-kernel@vger.kernel.org (open list)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web