Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1446628 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2016-07-19 20:10 +0200 |
| Last post | 2016-07-19 20:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] [media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-19 20:10 +0200
Re: [PATCH] [media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device" walter harms <wharms@bfs.de> - 2016-07-19 20:40 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-07-19 20:10 +0200 |
| Subject | [PATCH] [media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device" |
| Message-ID | <rWHCW-7l9-27@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 19 Jul 2016 19:54:16 +0200 The spi_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/v4l2-core/v4l2-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 5b80850..57cfe26a 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -291,7 +291,7 @@ struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev, error: /* If we have a client but no subdev, then something went wrong and we must unregister the client. */ - if (spi && sd == NULL) + if (!sd) spi_unregister_device(spi); return sd; -- 2.9.2
[toc] | [next] | [standalone]
| From | walter harms <wharms@bfs.de> |
|---|---|
| Date | 2016-07-19 20:40 +0200 |
| Subject | Re: [PATCH] [media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device" |
| Message-ID | <rWI5Y-7uZ-27@gated-at.bofh.it> |
| In reply to | #1446628 |
Am 19.07.2016 20:02, schrieb SF Markus Elfring: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 19 Jul 2016 19:54:16 +0200 > > The spi_unregister_device() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/media/v4l2-core/v4l2-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c > index 5b80850..57cfe26a 100644 > --- a/drivers/media/v4l2-core/v4l2-common.c > +++ b/drivers/media/v4l2-core/v4l2-common.c > @@ -291,7 +291,7 @@ struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev, > error: > /* If we have a client but no subdev, then something went wrong and > we must unregister the client. */ > - if (spi && sd == NULL) > + if (!sd) > spi_unregister_device(spi); > > return sd; if i read the code correct sd is always NULL at this point. so this was wrong in the first place and you must remove sd also. re, wh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web