Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1446410 > unrolled thread
| Started by | Wei Yongjun <weiyj_lk@163.com> |
|---|---|
| First post | 2016-07-19 14:50 +0200 |
| Last post | 2016-07-19 15:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] drm/vgem: Fix non static symbol warning Wei Yongjun <weiyj_lk@163.com> - 2016-07-19 14:50 +0200
Re: [PATCH -next] drm/vgem: Fix non static symbol warning Chris Wilson <chris@chris-wilson.co.uk> - 2016-07-19 15:00 +0200
Re: [PATCH -next] drm/vgem: Fix non static symbol warning Daniel Vetter <daniel@ffwll.ch> - 2016-07-19 15:10 +0200
| From | Wei Yongjun <weiyj_lk@163.com> |
|---|---|
| Date | 2016-07-19 14:50 +0200 |
| Subject | [PATCH -next] drm/vgem: Fix non static symbol warning |
| Message-ID | <rWCDg-44x-51@gated-at.bofh.it> |
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warning:
drivers/gpu/drm/vgem/vgem_fence.c:75:24: warning:
symbol 'vgem_fence_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/gpu/drm/vgem/vgem_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c
index e77b522..59ef144 100644
--- a/drivers/gpu/drm/vgem/vgem_fence.c
+++ b/drivers/gpu/drm/vgem/vgem_fence.c
@@ -72,7 +72,7 @@ static void vgem_fence_timeline_value_str(struct fence *fence, char *str,
snprintf(str, size, "%u", fence_is_signaled(fence) ? fence->seqno : 0);
}
-const struct fence_ops vgem_fence_ops = {
+static const struct fence_ops vgem_fence_ops = {
.get_driver_name = vgem_fence_get_driver_name,
.get_timeline_name = vgem_fence_get_timeline_name,
.enable_signaling = vgem_fence_enable_signaling,
[toc] | [next] | [standalone]
| From | Chris Wilson <chris@chris-wilson.co.uk> |
|---|---|
| Date | 2016-07-19 15:00 +0200 |
| Message-ID | <rWCN0-47Q-5@gated-at.bofh.it> |
| In reply to | #1446410 |
On Tue, Jul 19, 2016 at 12:44:22PM +0000, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warning: > > drivers/gpu/drm/vgem/vgem_fence.c:75:24: warning: > symbol 'vgem_fence_ops' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Thanks, Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2016-07-19 15:10 +0200 |
| Message-ID | <rWCWD-4qE-41@gated-at.bofh.it> |
| In reply to | #1446414 |
On Tue, Jul 19, 2016 at 01:51:03PM +0100, Chris Wilson wrote: > On Tue, Jul 19, 2016 at 12:44:22PM +0000, Wei Yongjun wrote: > > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > > > Fixes the following sparse warning: > > > > drivers/gpu/drm/vgem/vgem_fence.c:75:24: warning: > > symbol 'vgem_fence_ops' was not declared. Should it be static? > > > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Thanks, > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Merged to drm-misc, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web