Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444824 > unrolled thread

[patch v2] tools/vm/slabinfo: fix an unintentional printf

Back to article view | Back to linux.kernel

Contents

  [patch v2] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-16 14:30 +0200
    Re: [patch v2] tools/vm/slabinfo: fix an unintentional printf Christoph Lameter <cl@linux.com> - 2016-07-18 02:40 +0200

#1444824 — [patch v2] tools/vm/slabinfo: fix an unintentional printf

The curly braces are missing here so we print stuff unintentionally.

Fixes: 9da4714a2d44 ('slub: slabinfo update for cmpxchg handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Fix typo in git hash

diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index 7cf6e17..b9d34b3 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm/slabinfo.c
@@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
 			s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
 	}
 
-	if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
+	if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
 		printf("\nCmpxchg_double Looping\n------------------------\n");
 		printf("Locked Cmpxchg Double redos   %lu\nUnlocked Cmpxchg Double redos %lu\n",
 			s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
+	}
 }
 
 static void report(struct slabinfo *s)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [next] | [standalone]

#1445142

Acked-by: Christoph Lameter <cl@linux.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web