Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444644 > unrolled thread

[PATCH 3/3] perf/core: enabling mapping of the stop filters

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 3/3] perf/core: enabling mapping of the stop filters Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-16 00:30 +0200
    Re: [PATCH 3/3] perf/core: enabling mapping of the stop filters Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-07-18 13:40 +0200

#1444644 — [PATCH 3/3] perf/core: enabling mapping of the stop filters

At this time function perf_addr_filter_needs_mmap() will _not_
return true on a user space 'stop' filter.  But stop filters
needs exactly the same kind of mapping that range and start
filters get.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index b9aa8f0ff070..b0bf00c728c2 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6498,7 +6498,7 @@ got_name:
  */
 static bool perf_addr_filter_needs_mmap(struct perf_addr_filter *filter)
 {
-	return filter->filter && filter->inode;
+	return filter->inode;
 }
 
 /*
-- 
2.7.4

[toc] | [next] | [standalone]

#1445408

Mathieu Poirier <mathieu.poirier@linaro.org> writes:

> At this time function perf_addr_filter_needs_mmap() will _not_
> return true on a user space 'stop' filter.  But stop filters
> needs exactly the same kind of mapping that range and start
> filters get.

Indeed.

>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index b9aa8f0ff070..b0bf00c728c2 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6498,7 +6498,7 @@ got_name:
>   */
>  static bool perf_addr_filter_needs_mmap(struct perf_addr_filter *filter)
>  {
> -	return filter->filter && filter->inode;
> +	return filter->inode;
>  }

Maybe kill the function altogether and instead:

diff --git a/kernel/events/core.c b/kernel/events/core.c
index a001be5d4b..bc8e1ad170 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7905,7 +7905,8 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
 	list_for_each_entry(filter, &ifh->list, entry) {
 		event->addr_filters_offs[count] = 0;
 
-		if (perf_addr_filter_needs_mmap(filter))
+		/* file-based filter */
+		if (filter->inode)
 			event->addr_filters_offs[count] =
 				perf_addr_filter_apply(filter, mm);

Thanks,
--
Alex

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web