Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444595 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-07-15 23:20 +0200 |
| Last post | 2016-07-16 05:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-15 23:20 +0200
Re: [patch] tools/vm/slabinfo: fix an unintentional printf Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-07-16 05:40 +0200
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-07-15 23:20 +0200 |
| Subject | [patch] tools/vm/slabinfo: fix an unintentional printf |
| Message-ID | <rViGB-3uN-1@gated-at.bofh.it> |
The curly braces are missing here so we print stuff unintentionally.
Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index 7cf6e17..b9d34b3 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm/slabinfo.c
@@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
}
- if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
+ if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
printf("\nCmpxchg_double Looping\n------------------------\n");
printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n",
s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
+ }
}
static void report(struct slabinfo *s)
[toc] | [next] | [standalone]
| From | Sergey Senozhatsky <sergey.senozhatsky@gmail.com> |
|---|---|
| Date | 2016-07-16 05:40 +0200 |
| Message-ID | <rVoCm-750-3@gated-at.bofh.it> |
| In reply to | #1444595 |
On (07/16/16 00:12), Dan Carpenter wrote:
> The curly braces are missing here so we print stuff unintentionally.
>
> Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling')
Hello,
a minor correction:
it's 9da4714a2d44
not 9da4714a2d4f
-ss
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
> index 7cf6e17..b9d34b3 100644
> --- a/tools/vm/slabinfo.c
> +++ b/tools/vm/slabinfo.c
> @@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
> s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
> }
>
> - if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
> + if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
> printf("\nCmpxchg_double Looping\n------------------------\n");
> printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n",
> s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
> + }
> }
>
> static void report(struct slabinfo *s)
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web