Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444014 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-07-15 09:50 +0200 |
| Last post | 2016-07-15 23:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Arnd Bergmann <arnd@arndb.de> - 2016-07-15 09:50 +0200
Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-07-15 14:10 +0200
Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Steven Rostedt <rostedt@goodmis.org> - 2016-07-15 17:40 +0200
Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Steven Rostedt <rostedt@goodmis.org> - 2016-07-15 20:40 +0200
Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Arnd Bergmann <arnd@arndb.de> - 2016-07-15 23:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-15 09:50 +0200 |
| Subject | Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) |
| Message-ID | <rV62K-47o-17@gated-at.bofh.it> |
On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote: > > arm64-allnoconfig > /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > arm64-allmodconfig > /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > arm-multi_v7_defconfig > /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > arm-allmodconfig > /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > arm-allnoconfig > /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > arm64-defconfig > /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] These all started failing yesterday with v3.14.72-rt76, before it was v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75) Arnd
[toc] | [next] | [standalone]
| From | Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
|---|---|
| Date | 2016-07-15 14:10 +0200 |
| Message-ID | <rVa6n-6K7-43@gated-at.bofh.it> |
| In reply to | #1444014 |
+ Steven * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]: >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote: >> >> arm64-allnoconfig >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] >> >> arm64-allmodconfig >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] >> >> arm-multi_v7_defconfig >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] >> >> arm-allmodconfig >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] >> >> arm-allnoconfig >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] >> >> arm64-defconfig >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > >These all started failing yesterday with v3.14.72-rt76, before it was > > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75) > > Arnd Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2016-07-15 17:40 +0200 |
| Message-ID | <rVdnA-ap-31@gated-at.bofh.it> |
| In reply to | #1444235 |
On Fri, 15 Jul 2016 14:08:37 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > + Steven > > * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]: > > >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote: > >> > >> arm64-allnoconfig > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > >> > >> arm64-allmodconfig > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > >> > >> arm-multi_v7_defconfig > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > >> > >> arm-allmodconfig > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > >> > >> arm-allnoconfig > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > >> > >> arm64-defconfig > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > > >These all started failing yesterday with v3.14.72-rt76, before it was > > > > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75) > > Bah, thanks for the report. I hope I have time before to fix this today, otherwise, I'll need to do it when I get back from my travels. -- Steve
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2016-07-15 20:40 +0200 |
| Message-ID | <rVgbL-1Sh-5@gated-at.bofh.it> |
| In reply to | #1444235 |
On Fri, 15 Jul 2016 14:08:37 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> + Steven
>
> * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]:
>
> >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:
> >>
> >> arm64-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm64-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-multi_v7_defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm64-defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >
> >These all started failing yesterday with v3.14.72-rt76, before it was
> >
> > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
> >
> > Arnd
>
Arnd,
Does this fix the issue?
-- Steve
diff --git a/include/asm-generic/preempt.h b/include/asm-generic/preempt.h
index 65759d8b0b46..25c09df2c046 100644
--- a/include/asm-generic/preempt.h
+++ b/include/asm-generic/preempt.h
@@ -7,7 +7,7 @@
static __always_inline int preempt_count(void)
{
- return READ_ONCE(current_thread_info()->preempt_count);
+ return ACCESS_ONCE(current_thread_info()->preempt_count);
}
static __always_inline volatile int *preempt_count_ptr(void)
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-15 23:00 +0200 |
| Message-ID | <rVinh-38N-59@gated-at.bofh.it> |
| In reply to | #1444510 |
On Friday, July 15, 2016 2:34:10 PM CEST Steven Rostedt wrote: > > * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]: > > > > >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote: > > >> > > >> arm64-allnoconfig > > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > >> > > >> arm64-allmodconfig > > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > >> > > >> arm-multi_v7_defconfig > > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > >> > > >> arm-allmodconfig > > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > >> > > >> arm-allnoconfig > > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > >> > > >> arm64-defconfig > > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration] > > > > > >These all started failing yesterday with v3.14.72-rt76, before it was > > > > > > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75) > > > > > > Arnd > > > > Arnd, > > Does this fix the issue? > From looking at it I'm fairly sure it addresses the build problem, and semantically it looks correct as well, but I haven't had a chance to test it on my machine yet. The build results above come from Mark Brown's automated build setup, so your testing is as good as mine in reproducing it. Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web