Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444134 > unrolled thread
| Started by | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| First post | 2016-07-15 12:10 +0200 |
| Last post | 2016-07-19 09:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFCv2 2/4] perf: util: Add more cpu_map helpers Mark Rutland <mark.rutland@arm.com> - 2016-07-15 12:10 +0200
Re: [RFCv2 2/4] perf: util: Add more cpu_map helpers Jiri Olsa <jolsa@redhat.com> - 2016-07-18 16:40 +0200
[tip:perf/core] perf cpu_map: Add more helpers tip-bot for Mark Rutland <tipbot@zytor.com> - 2016-07-19 09:00 +0200
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2016-07-15 12:10 +0200 |
| Subject | [RFCv2 2/4] perf: util: Add more cpu_map helpers |
| Message-ID | <rV8ed-5Bf-15@gated-at.bofh.it> |
In some cases it's necessry to figure out the map-local index of a given
Linux logical CPU ID. Add a new helper, cpu_map__idx, to acquire this.
As the logic is largely the same as the existing cpu_map__has, this is
rewritten in terms of the new helper.
At the same time, add the inverse operation, cpu_map__cpu, which yields
the logical CPU id for a map-local index. While this can be performed
manually, wrapping this in a helper can make code more legible.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org
---
tools/perf/util/cpumap.c | 14 ++++++++++++--
tools/perf/util/cpumap.h | 2 ++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
index 02d8016..efc88fe 100644
--- a/tools/perf/util/cpumap.c
+++ b/tools/perf/util/cpumap.c
@@ -590,12 +590,22 @@ int cpu__setup_cpunode_map(void)
bool cpu_map__has(struct cpu_map *cpus, int cpu)
{
+ return cpu_map__idx(cpus, cpu) != -1;
+}
+
+int cpu_map__idx(struct cpu_map *cpus, int cpu)
+{
int i;
for (i = 0; i < cpus->nr; ++i) {
if (cpus->map[i] == cpu)
- return true;
+ return i;
}
- return false;
+ return -1;
+}
+
+int cpu_map__cpu(struct cpu_map *cpus, int idx)
+{
+ return cpus->map[idx];
}
diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
index 1a0a350..46f7642 100644
--- a/tools/perf/util/cpumap.h
+++ b/tools/perf/util/cpumap.h
@@ -67,5 +67,7 @@ int cpu_map__build_map(struct cpu_map *cpus, struct cpu_map **res,
int (*f)(struct cpu_map *map, int cpu, void *data),
void *data);
+int cpu_map__cpu(struct cpu_map *cpus, int idx);
bool cpu_map__has(struct cpu_map *cpus, int cpu);
+int cpu_map__idx(struct cpu_map *cpus, int cpu);
#endif /* __PERF_CPUMAP_H */
--
1.9.1
[toc] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2016-07-18 16:40 +0200 |
| Message-ID | <rWhSa-7qj-45@gated-at.bofh.it> |
| In reply to | #1444134 |
On Fri, Jul 15, 2016 at 11:08:11AM +0100, Mark Rutland wrote:
> In some cases it's necessry to figure out the map-local index of a given
> Linux logical CPU ID. Add a new helper, cpu_map__idx, to acquire this.
> As the logic is largely the same as the existing cpu_map__has, this is
> rewritten in terms of the new helper.
>
> At the same time, add the inverse operation, cpu_map__cpu, which yields
> the logical CPU id for a map-local index. While this can be performed
> manually, wrapping this in a helper can make code more legible.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: linux-kernel@vger.kernel.org
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> tools/perf/util/cpumap.c | 14 ++++++++++++--
> tools/perf/util/cpumap.h | 2 ++
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
> index 02d8016..efc88fe 100644
> --- a/tools/perf/util/cpumap.c
> +++ b/tools/perf/util/cpumap.c
> @@ -590,12 +590,22 @@ int cpu__setup_cpunode_map(void)
>
> bool cpu_map__has(struct cpu_map *cpus, int cpu)
> {
> + return cpu_map__idx(cpus, cpu) != -1;
> +}
> +
> +int cpu_map__idx(struct cpu_map *cpus, int cpu)
> +{
> int i;
>
> for (i = 0; i < cpus->nr; ++i) {
> if (cpus->map[i] == cpu)
> - return true;
> + return i;
> }
>
> - return false;
> + return -1;
> +}
> +
> +int cpu_map__cpu(struct cpu_map *cpus, int idx)
> +{
> + return cpus->map[idx];
> }
> diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
> index 1a0a350..46f7642 100644
> --- a/tools/perf/util/cpumap.h
> +++ b/tools/perf/util/cpumap.h
> @@ -67,5 +67,7 @@ int cpu_map__build_map(struct cpu_map *cpus, struct cpu_map **res,
> int (*f)(struct cpu_map *map, int cpu, void *data),
> void *data);
>
> +int cpu_map__cpu(struct cpu_map *cpus, int idx);
> bool cpu_map__has(struct cpu_map *cpus, int cpu);
> +int cpu_map__idx(struct cpu_map *cpus, int cpu);
> #endif /* __PERF_CPUMAP_H */
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Mark Rutland <tipbot@zytor.com> |
|---|---|
| Date | 2016-07-19 09:00 +0200 |
| Subject | [tip:perf/core] perf cpu_map: Add more helpers |
| Message-ID | <rWxaz-FB-51@gated-at.bofh.it> |
| In reply to | #1444134 |
Commit-ID: 9a6c582d57a0fc37fa4e13a69d9129fb3d98a401
Gitweb: http://git.kernel.org/tip/9a6c582d57a0fc37fa4e13a69d9129fb3d98a401
Author: Mark Rutland <mark.rutland@arm.com>
AuthorDate: Fri, 15 Jul 2016 11:08:11 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 18 Jul 2016 19:42:47 -0300
perf cpu_map: Add more helpers
In some cases it's necessry to figure out the map-local index of a given
Linux logical CPU ID. Add a new helper, cpu_map__idx, to acquire this.
As the logic is largely the same as the existing cpu_map__has, this is
rewritten in terms of the new helper.
At the same time, add the inverse operation, cpu_map__cpu, which yields
the logical CPU id for a map-local index. While this can be performed
manually, wrapping this in a helper can make code more legible.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1468577293-19667-3-git-send-email-mark.rutland@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/cpumap.c | 14 ++++++++++++--
tools/perf/util/cpumap.h | 2 ++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
index 15f83ac..2c0b522 100644
--- a/tools/perf/util/cpumap.c
+++ b/tools/perf/util/cpumap.c
@@ -589,14 +589,24 @@ int cpu__setup_cpunode_map(void)
bool cpu_map__has(struct cpu_map *cpus, int cpu)
{
+ return cpu_map__idx(cpus, cpu) != -1;
+}
+
+int cpu_map__idx(struct cpu_map *cpus, int cpu)
+{
int i;
for (i = 0; i < cpus->nr; ++i) {
if (cpus->map[i] == cpu)
- return true;
+ return i;
}
- return false;
+ return -1;
+}
+
+int cpu_map__cpu(struct cpu_map *cpus, int idx)
+{
+ return cpus->map[idx];
}
size_t cpu_map__snprint(struct cpu_map *map, char *buf, size_t size)
diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
index 206dc55..06bd689 100644
--- a/tools/perf/util/cpumap.h
+++ b/tools/perf/util/cpumap.h
@@ -68,5 +68,7 @@ int cpu_map__build_map(struct cpu_map *cpus, struct cpu_map **res,
int (*f)(struct cpu_map *map, int cpu, void *data),
void *data);
+int cpu_map__cpu(struct cpu_map *cpus, int idx);
bool cpu_map__has(struct cpu_map *cpus, int cpu);
+int cpu_map__idx(struct cpu_map *cpus, int cpu);
#endif /* __PERF_CPUMAP_H */
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web