Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443318 > unrolled thread

[patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

Started byJiri Pirko <jiri@resnulli.us>
First post2016-07-14 11:40 +0200
Last post2016-07-15 07:20 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint Jiri Pirko <jiri@resnulli.us> - 2016-07-14 11:40 +0200
    Re: [patch net-next 1/2] tracing: change owner name to driver name  for devlink hwmsg tracepoint Randy Dunlap <rdunlap@infradead.org> - 2016-07-14 19:10 +0200
      Re: [patch net-next 1/2] tracing: change owner name to driver name  for devlink hwmsg tracepoint Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 19:20 +0200
    Re: [patch net-next 1/2] tracing: change owner name to driver name  for devlink hwmsg tracepoint David Miller <davem@davemloft.net> - 2016-07-15 07:20 +0200

#1443318 — [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

FromJiri Pirko <jiri@resnulli.us>
Date2016-07-14 11:40 +0200
Subject[patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint
Message-ID<rULhD-7Tt-3@gated-at.bofh.it>
From: Jiri Pirko <jiri@mellanox.com>

Turned on that driver->owner which is struct module is not available when
modules are disabled. Better to depend on a driver name which is
always available.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: e5224f0fe2 ("devlink: add hardware messages tracing facility")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 include/trace/events/devlink.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
index 333c32a..77dce71 100644
--- a/include/trace/events/devlink.h
+++ b/include/trace/events/devlink.h
@@ -22,7 +22,7 @@ TRACE_EVENT(devlink_hwmsg,
 	TP_STRUCT__entry(
 		__string(bus_name, devlink->dev->bus->name)
 		__string(dev_name, dev_name(devlink->dev))
-		__string(owner_name, devlink->dev->driver->owner->name)
+		__string(driver_name, devlink->dev->driver->name)
 		__field(bool, incoming)
 		__field(unsigned long, type)
 		__dynamic_array(u8, buf, len)
@@ -32,16 +32,16 @@ TRACE_EVENT(devlink_hwmsg,
 	TP_fast_assign(
 		__assign_str(bus_name, devlink->dev->bus->name);
 		__assign_str(dev_name, dev_name(devlink->dev));
-		__assign_str(owner_name, devlink->dev->driver->owner->name);
+		__assign_str(driver_name, devlink->dev->driver->name);
 		__entry->incoming = incoming;
 		__entry->type = type;
 		memcpy(__get_dynamic_array(buf), buf, len);
 		__entry->len = len;
 	),
 
-	TP_printk("bus_name=%s dev_name=%s owner_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
+	TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
 		  __get_str(bus_name), __get_str(dev_name),
-		  __get_str(owner_name), __entry->incoming, __entry->type,
+		  __get_str(driver_name), __entry->incoming, __entry->type,
 		  (int) __entry->len, __get_dynamic_array(buf), __entry->len)
 );
 
-- 
2.5.5

[toc] | [next] | [standalone]

#1443601 — Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

FromRandy Dunlap <rdunlap@infradead.org>
Date2016-07-14 19:10 +0200
SubjectRe: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint
Message-ID<rUSj7-41y-3@gated-at.bofh.it>
In reply to#1443318
On 07/14/16 02:37, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> Turned on that driver->owner which is struct module is not available when
> modules are disabled. Better to depend on a driver name which is
> always available.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: e5224f0fe2 ("devlink: add hardware messages tracing facility")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  include/trace/events/devlink.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
> index 333c32a..77dce71 100644
> --- a/include/trace/events/devlink.h
> +++ b/include/trace/events/devlink.h
> @@ -22,7 +22,7 @@ TRACE_EVENT(devlink_hwmsg,
>  	TP_STRUCT__entry(
>  		__string(bus_name, devlink->dev->bus->name)
>  		__string(dev_name, dev_name(devlink->dev))
> -		__string(owner_name, devlink->dev->driver->owner->name)
> +		__string(driver_name, devlink->dev->driver->name)
>  		__field(bool, incoming)
>  		__field(unsigned long, type)
>  		__dynamic_array(u8, buf, len)
> @@ -32,16 +32,16 @@ TRACE_EVENT(devlink_hwmsg,
>  	TP_fast_assign(
>  		__assign_str(bus_name, devlink->dev->bus->name);
>  		__assign_str(dev_name, dev_name(devlink->dev));
> -		__assign_str(owner_name, devlink->dev->driver->owner->name);
> +		__assign_str(driver_name, devlink->dev->driver->name);
>  		__entry->incoming = incoming;
>  		__entry->type = type;
>  		memcpy(__get_dynamic_array(buf), buf, len);
>  		__entry->len = len;
>  	),
>  
> -	TP_printk("bus_name=%s dev_name=%s owner_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
> +	TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
>  		  __get_str(bus_name), __get_str(dev_name),
> -		  __get_str(owner_name), __entry->incoming, __entry->type,
> +		  __get_str(driver_name), __entry->incoming, __entry->type,
>  		  (int) __entry->len, __get_dynamic_array(buf), __entry->len)
>  );
>  
> 


-- 
~Randy

[toc] | [prev] | [next] | [standalone]

#1443611 — Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-07-14 19:20 +0200
SubjectRe: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint
Message-ID<rUSsO-45I-15@gated-at.bofh.it>
In reply to#1443601
On Thu, 14 Jul 2016 10:07:33 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 07/14/16 02:37, Jiri Pirko wrote:
> > From: Jiri Pirko <jiri@mellanox.com>
> > 
> > Turned on that driver->owner which is struct module is not available when
> > modules are disabled. Better to depend on a driver name which is
> > always available.
> > 
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: e5224f0fe2 ("devlink: add hardware messages tracing facility")
> > Signed-off-by: Jiri Pirko <jiri@mellanox.com>  
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>

I may as well add mine too...

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

[toc] | [prev] | [next] | [standalone]

#1443948 — Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

FromDavid Miller <davem@davemloft.net>
Date2016-07-15 07:20 +0200
SubjectRe: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint
Message-ID<rV3Hz-2Ms-7@gated-at.bofh.it>
In reply to#1443318
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 14 Jul 2016 11:37:28 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Turned on that driver->owner which is struct module is not available when
> modules are disabled. Better to depend on a driver name which is
> always available.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: e5224f0fe2 ("devlink: add hardware messages tracing facility")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web