Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1440968 > unrolled thread

Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2016-07-12 01:40 +0200
Last post2016-07-13 18:10 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-12 01:40 +0200
    Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS Stewart Smith <stewart@linux.vnet.ibm.com> - 2016-07-13 05:10 +0200
      Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> - 2016-07-13 15:40 +0200
        Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-13 17:20 +0200
          Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> - 2016-07-13 18:10 +0200

#1440968 — Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-07-12 01:40 +0200
SubjectRe: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS
Message-ID<rTSXT-5mD-3@gated-at.bofh.it>
Hi Paulo,

On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:
>
> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl
> index 2280539..813ffcc 100644
> --- a/drivers/crypto/vmx/aesp8-ppc.pl
> +++ b/drivers/crypto/vmx/aesp8-ppc.pl
> @@ -1,4 +1,11 @@
> -#!/usr/bin/env perl
> +#! /usr/bin/env perl
> +# Copyright 2014-2016 The OpenSSL Project Authors. All Rights Reserved.
> +#
> +# Licensed under the OpenSSL license (the "License").  You may not use
> +# this file except in compliance with the License.  You can obtain a copy
> +# in the file LICENSE in the source distribution or at
> +# https://www.openssl.org/source/license.html

So, I assume that this license is compatible with the GPLv2?

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1441977

FromStewart Smith <stewart@linux.vnet.ibm.com>
Date2016-07-13 05:10 +0200
Message-ID<rUiIF-5G6-3@gated-at.bofh.it>
In reply to#1440968
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:
>>
>> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl
>> index 2280539..813ffcc 100644
>> --- a/drivers/crypto/vmx/aesp8-ppc.pl
>> +++ b/drivers/crypto/vmx/aesp8-ppc.pl
>> @@ -1,4 +1,11 @@
>> -#!/usr/bin/env perl
>> +#! /usr/bin/env perl
>> +# Copyright 2014-2016 The OpenSSL Project Authors. All Rights Reserved.
>> +#
>> +# Licensed under the OpenSSL license (the "License").  You may not use
>> +# this file except in compliance with the License.  You can obtain a copy
>> +# in the file LICENSE in the source distribution or at
>> +# https://www.openssl.org/source/license.html
>
> So, I assume that this license is compatible with the GPLv2?

https://people.gnome.org/~markmc/openssl-and-the-gpl.html has an
explanation and points to:
https://www.openssl.org/docs/faq.html#LEGAL2

which makes it anything but clearer.

it appears the answer is "probably not, unless you have an explicit
exemption in your license"

-- 
Stewart Smith
OPAL Architect, IBM.

[toc] | [prev] | [next] | [standalone]


#1442463

FromPaulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
Date2016-07-13 15:40 +0200
Message-ID<rUsym-3Gm-9@gated-at.bofh.it>
In reply to#1441977
Wed, Jul 13, 2016 at 01:05:03PM +1000, Stewart Smith wrote:
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
> > On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:
> >>
> >> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl
> >> index 2280539..813ffcc 100644
> >> --- a/drivers/crypto/vmx/aesp8-ppc.pl
> >> +++ b/drivers/crypto/vmx/aesp8-ppc.pl
> >> @@ -1,4 +1,11 @@
> >> -#!/usr/bin/env perl
> >> +#! /usr/bin/env perl
> >> +# Copyright 2014-2016 The OpenSSL Project Authors. All Rights Reserved.
> >> +#
> >> +# Licensed under the OpenSSL license (the "License").  You may not use
> >> +# this file except in compliance with the License.  You can obtain a copy
> >> +# in the file LICENSE in the source distribution or at
> >> +# https://www.openssl.org/source/license.html
> >
> > So, I assume that this license is compatible with the GPLv2?

Andy released this code under the cryptogams license:

# ====================================================================
# Written by Andy Polyakov <appro@openssl.org> for the OpenSSL
# project. The module is, however, dual licensed under OpenSSL and
# CRYPTOGAMS licenses depending on where you obtain it. For further
# details see http://www.openssl.org/~appro/cryptogams/.
# ====================================================================

The license is GPL compatible:

ALTERNATIVELY, provided that this notice is retained in full, this
product may be distributed under the terms of the GNU General Public
License (GPL), in which case the provisions of the GPL apply INSTEAD OF
those given above.

> 
> https://people.gnome.org/~markmc/openssl-and-the-gpl.html has an
> explanation and points to:
> https://www.openssl.org/docs/faq.html#LEGAL2
> 
> which makes it anything but clearer.
> 
> it appears the answer is "probably not, unless you have an explicit
> exemption in your license"
> 
> -- 
> Stewart Smith
> OPAL Architect, IBM.

-- 
Paulo Flabiano Smorigo
IBM Linux Technology Center

[toc] | [prev] | [next] | [standalone]


#1442542

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-07-13 17:20 +0200
Message-ID<rUu78-4Nq-25@gated-at.bofh.it>
In reply to#1442463
Hi Paulo,

On Wed, 13 Jul 2016 10:34:27 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:
>
> Wed, Jul 13, 2016 at 01:05:03PM +1000, Stewart Smith wrote:
> > Stephen Rothwell <sfr@canb.auug.org.au> writes:  
> > > On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:  
> > >>
> > >> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl
> > >> index 2280539..813ffcc 100644
> > >> --- a/drivers/crypto/vmx/aesp8-ppc.pl
> > >> +++ b/drivers/crypto/vmx/aesp8-ppc.pl
> > >> @@ -1,4 +1,11 @@
> > >> -#!/usr/bin/env perl
> > >> +#! /usr/bin/env perl
> > >> +# Copyright 2014-2016 The OpenSSL Project Authors. All Rights Reserved.
> > >> +#
> > >> +# Licensed under the OpenSSL license (the "License").  You may not use
> > >> +# this file except in compliance with the License.  You can obtain a copy
> > >> +# in the file LICENSE in the source distribution or at
> > >> +# https://www.openssl.org/source/license.html  
> > >
> > > So, I assume that this license is compatible with the GPLv2?  
> 
> Andy released this code under the cryptogams license:
> 
> # ====================================================================
> # Written by Andy Polyakov <appro@openssl.org> for the OpenSSL
> # project. The module is, however, dual licensed under OpenSSL and
> # CRYPTOGAMS licenses depending on where you obtain it. For further
> # details see http://www.openssl.org/~appro/cryptogams/.
> # ====================================================================

Yeah, this license statement is already in the file being patched, so
why is the above license (and Copyright notice) being added above the
existing one?

> The license is GPL compatible:

Good, thanks.

> ALTERNATIVELY, provided that this notice is retained in full, this
> product may be distributed under the terms of the GNU General Public
> License (GPL), in which case the provisions of the GPL apply INSTEAD OF
> those given above.

Which is not in this file or the patch, but presumably in the referred
to web page.

Of course, I am not a lawyer :-)
-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]


#1442579

FromPaulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
Date2016-07-13 18:10 +0200
Message-ID<rUuTw-5nh-33@gated-at.bofh.it>
In reply to#1442542
Thu, Jul 14, 2016 at 01:11:58AM +1000, Stephen Rothwell wrote:
> Hi Paulo,
> 
> On Wed, 13 Jul 2016 10:34:27 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:
> >
> > Wed, Jul 13, 2016 at 01:05:03PM +1000, Stewart Smith wrote:
> > > Stephen Rothwell <sfr@canb.auug.org.au> writes:  
> > > > On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> wrote:  
> > > >>
> > > >> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl
> > > >> index 2280539..813ffcc 100644
> > > >> --- a/drivers/crypto/vmx/aesp8-ppc.pl
> > > >> +++ b/drivers/crypto/vmx/aesp8-ppc.pl
> > > >> @@ -1,4 +1,11 @@
> > > >> -#!/usr/bin/env perl
> > > >> +#! /usr/bin/env perl
> > > >> +# Copyright 2014-2016 The OpenSSL Project Authors. All Rights Reserved.
> > > >> +#
> > > >> +# Licensed under the OpenSSL license (the "License").  You may not use
> > > >> +# this file except in compliance with the License.  You can obtain a copy
> > > >> +# in the file LICENSE in the source distribution or at
> > > >> +# https://www.openssl.org/source/license.html  
> > > >
> > > > So, I assume that this license is compatible with the GPLv2?  
> > 
> > Andy released this code under the cryptogams license:
> > 
> > # ====================================================================
> > # Written by Andy Polyakov <appro@openssl.org> for the OpenSSL
> > # project. The module is, however, dual licensed under OpenSSL and
> > # CRYPTOGAMS licenses depending on where you obtain it. For further
> > # details see http://www.openssl.org/~appro/cryptogams/.
> > # ====================================================================
> 
> Yeah, this license statement is already in the file being patched, so
> why is the above license (and Copyright notice) being added above the
> existing one?

aesp8-ppc.pl from Linux is almost the same as the one from OpenSSL and we do
that so we can keep it updated on both projects.
The above license lines were added to all pl files in OpenSSL so it ended up
here but since the author published it as cryptogams too we are ok.

> 
> > The license is GPL compatible:
> 
> Good, thanks.
> 
> > ALTERNATIVELY, provided that this notice is retained in full, this
> > product may be distributed under the terms of the GNU General Public
> > License (GPL), in which case the provisions of the GPL apply INSTEAD OF
> > those given above.
> 
> Which is not in this file or the patch, but presumably in the referred
> to web page.

Yes, that comment is from the url pointed in the code.

> 
> Of course, I am not a lawyer :-)
> -- 
> Cheers,
> Stephen Rothwell
> 

-- 
Paulo Flabiano Smorigo
IBM Linux Technology Center

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web