Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1442315 > unrolled thread

Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly  non-modular Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-07-13 12:40 +0200
    Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-14 00:00 +0200

#1442315 — Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

On 07/04/2016 11:12 PM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> arch/arm/mach-s5pv210/Kconfig:config ARCH_S5PV210
> arch/arm/mach-s5pv210/Kconfig:  bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since this code is already not using module_init, case, the init
> ordering remains unchanged with this commit.
> 
> We also delete the MODULE_LICENSE tags etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

In case this is going to be applied directly to current clk-next:

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

[toc] | [next] | [standalone]

#1442895 — Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

Quoting Sylwester Nawrocki (2016-07-13 03:32:42)
> On 07/04/2016 11:12 PM, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> > 
> > arch/arm/mach-s5pv210/Kconfig:config ARCH_S5PV210
> > arch/arm/mach-s5pv210/Kconfig:  bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7
> > 
> > ...meaning that it currently is not being built as a module by anyone.
> > 
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> > 
> > We explicitly disallow a driver unbind, since that doesn't have a
> > sensible use case anyway, and it allows us to drop the ".remove"
> > code for non-modular drivers.
> > 
> > Since this code is already not using module_init, case, the init
> > ordering remains unchanged with this commit.
> > 
> > We also delete the MODULE_LICENSE tags etc. since all that information
> > is already contained at the top of the file in the comments.
> > 
> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > Cc: linux-samsung-soc@vger.kernel.org
> > Cc: linux-clk@vger.kernel.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> In case this is going to be applied directly to current clk-next:
> 
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 

Applied to clk-next.

I know that we normally take PRs for the samsung clk stuff, but this
late in the cycle I'm OK to simply pick individual patches.

Thanks,
Mike

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web