Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443616 > unrolled thread

[PATCH] metag: Remove duplicate KERN_<LEVEL> prefix

Back to article view | Back to linux.kernel

Contents

  [PATCH] metag: Remove duplicate KERN_<LEVEL> prefix Joe Perches <joe@perches.com> - 2016-07-14 19:20 +0200
    Re: [PATCH] metag: Remove duplicate KERN_<LEVEL> prefix James Hogan <james.hogan@imgtec.com> - 2016-07-15 11:20 +0200

#1443616 — [PATCH] metag: Remove duplicate KERN_<LEVEL> prefix

Use a bare printk to avoid a duplicate KERN_<LEVEL> in logging output.

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/metag/mm/fault.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/metag/mm/fault.c b/arch/metag/mm/fault.c
index 372783a..c765b36 100644
--- a/arch/metag/mm/fault.c
+++ b/arch/metag/mm/fault.c
@@ -187,7 +187,7 @@ bad_area_nosemaphore:
 
 		if (show_unhandled_signals && unhandled_signal(tsk, SIGSEGV) &&
 		    printk_ratelimit()) {
-			pr_info("%s%s[%d]: segfault at %lx pc %08x sp %08x write %d trap %#x (%s)",
+			printk("%s%s[%d]: segfault at %lx pc %08x sp %08x write %d trap %#x (%s)",
 			       task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
 			       tsk->comm, task_pid_nr(tsk), address,
 			       regs->ctx.CurrPC, regs->ctx.AX[0].U0,
-- 
2.8.0.rc4.16.g56331f8

[toc] | [next] | [standalone]

#1444096

[Multipart message — attachments visible in raw view] — view raw

Hi Joe,

On Thu, Jul 14, 2016 at 10:10:13AM -0700, Joe Perches wrote:
> Use a bare printk to avoid a duplicate KERN_<LEVEL> in logging output.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks, applied for 4.8.

This appears to have been introduced accidentally while I was checkpatch
cleaning ready for submitting arch/metag upstream.

Cheers
James

> ---
>  arch/metag/mm/fault.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/metag/mm/fault.c b/arch/metag/mm/fault.c
> index 372783a..c765b36 100644
> --- a/arch/metag/mm/fault.c
> +++ b/arch/metag/mm/fault.c
> @@ -187,7 +187,7 @@ bad_area_nosemaphore:
>  
>  		if (show_unhandled_signals && unhandled_signal(tsk, SIGSEGV) &&
>  		    printk_ratelimit()) {
> -			pr_info("%s%s[%d]: segfault at %lx pc %08x sp %08x write %d trap %#x (%s)",
> +			printk("%s%s[%d]: segfault at %lx pc %08x sp %08x write %d trap %#x (%s)",
>  			       task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
>  			       tsk->comm, task_pid_nr(tsk), address,
>  			       regs->ctx.CurrPC, regs->ctx.AX[0].U0,
> -- 
> 2.8.0.rc4.16.g56331f8
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web