Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1443069 > unrolled thread
| Started by | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| First post | 2016-07-14 06:40 +0200 |
| Last post | 2016-07-14 16:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-07-14 06:40 +0200
Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR Himanshu Madhani <himanshu.madhani@qlogic.com> - 2016-07-14 16:30 +0200
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-07-14 06:40 +0200 |
| Subject | Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR |
| Message-ID | <rUGBj-4Ig-3@gated-at.bofh.it> |
>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@suse.de> writes: Johannes> qla2xxx first calls request_irq() and then does the setup of Johannes> the queue entry data needed in the interrupt handlers in when Johannes> using MSI-X. This could lead to a NULL pointer dereference Johannes> when an IRQ fires between the request_irq() call and the Johannes> assignment of the qentry data structure to the rsp-> msix field. A possible case for such a race would be in the kdump Johannes> case when the HBA's IRQs are still enabled but the driver is Johannes> undergoing a new initialisation and thus is not aware of Johannes> already activated IRQs in the HBA. Qlogic folks: Please review! -- Martin K. Petersen Oracle Linux Engineering
[toc] | [next] | [standalone]
| From | Himanshu Madhani <himanshu.madhani@qlogic.com> |
|---|---|
| Date | 2016-07-14 16:30 +0200 |
| Subject | Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR |
| Message-ID | <rUPOh-2or-17@gated-at.bofh.it> |
| In reply to | #1443069 |
On 7/13/16, 9:28 PM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote: >>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@suse.de> writes: > >Johannes> qla2xxx first calls request_irq() and then does the setup of >Johannes> the queue entry data needed in the interrupt handlers in when >Johannes> using MSI-X. This could lead to a NULL pointer dereference >Johannes> when an IRQ fires between the request_irq() call and the >Johannes> assignment of the qentry data structure to the >rsp-> msix field. A possible case for such a race would be in the kdump >Johannes> case when the HBA's IRQs are still enabled but the driver is >Johannes> undergoing a new initialisation and thus is not aware of >Johannes> already activated IRQs in the HBA. > >Qlogic folks: Please review! Looks Good. Reviewed-by: Himanshu Madhani <himanshu.madhani@qlogic.com> > >-- >Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web