Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1442295 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-07-13 12:20 +0200 |
| Last post | 2016-07-14 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] avr32: off by one in at32_init_pio() Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-13 12:20 +0200
Re: [patch] avr32: off by one in at32_init_pio() Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2016-07-14 13:10 +0200
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-07-13 12:20 +0200 |
| Subject | [patch] avr32: off by one in at32_init_pio() |
| Message-ID | <rUpqN-1JD-3@gated-at.bofh.it> |
The pio_dev[] array has MAX_NR_PIO_DEVICES elements so the > should be
>=.
Fixes: 5f97f7f9400d ('[PATCH] avr32 architecture')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c
index 83c2a00..13d3fc4 100644
--- a/arch/avr32/mach-at32ap/pio.c
+++ b/arch/avr32/mach-at32ap/pio.c
@@ -435,7 +435,7 @@ void __init at32_init_pio(struct platform_device *pdev)
struct resource *regs;
struct pio_device *pio;
- if (pdev->id > MAX_NR_PIO_DEVICES) {
+ if (pdev->id >= MAX_NR_PIO_DEVICES) {
dev_err(&pdev->dev, "only %d PIO devices supported\n",
MAX_NR_PIO_DEVICES);
return;
[toc] | [next] | [standalone]
| From | Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> |
|---|---|
| Date | 2016-07-14 13:10 +0200 |
| Message-ID | <rUMGJ-ue-1@gated-at.bofh.it> |
| In reply to | #1442295 |
Around Wed 13 Jul 2016 13:08:55 +0300 or thereabout, Dan Carpenter wrote:
> The pio_dev[] array has MAX_NR_PIO_DEVICES elements so the > should be
>>=.
So it should, no off by one error in the kernel anyway, since at32ap700x only
probes 5 PIO instances.
> Fixes: 5f97f7f9400d ('[PATCH] avr32 architecture')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
I will add this to my linux-next branch for the next merge window.
> diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c
> index 83c2a00..13d3fc4 100644
> --- a/arch/avr32/mach-at32ap/pio.c
> +++ b/arch/avr32/mach-at32ap/pio.c
> @@ -435,7 +435,7 @@ void __init at32_init_pio(struct platform_device *pdev)
> struct resource *regs;
> struct pio_device *pio;
>
> - if (pdev->id > MAX_NR_PIO_DEVICES) {
> + if (pdev->id >= MAX_NR_PIO_DEVICES) {
> dev_err(&pdev->dev, "only %d PIO devices supported\n",
> MAX_NR_PIO_DEVICES);
> return;
>
--
mvh
Hans-Christian Noren Egtvedt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web