Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443298 > unrolled thread

[PATCH] Enclose multiple statements macros in a do while loop

Back to article view | Back to linux.kernel

Contents

  [PATCH] Enclose multiple statements macros in a do while loop Sunbing <sunbing@redflag-linux.com> - 2016-07-14 11:10 +0200
    Re: [PATCH] Enclose multiple statements macros in a do while loop Greg KH <gregkh@linuxfoundation.org> - 2016-07-15 02:40 +0200
      Re: [PATCH] Enclose multiple statements macros in a do while loop sunbing <sunbing@redflag-linux.com> - 2016-07-17 18:20 +0200

#1443298 — [PATCH] Enclose multiple statements macros in a do while loop

The formatting of macros definetion in ks7010/michael_mic.c is not
consistent with the general kernel coding style.

Fix it by the result of scripts/checkpatch.pl.

No functional changes.

Signed-off-by: Sunbing <sunbing.linux@gmail.com>
---
 drivers/staging/ks7010/michael_mic.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c
index e14c109..ad4f779 100644
--- a/drivers/staging/ks7010/michael_mic.c
+++ b/drivers/staging/ks7010/michael_mic.c
@@ -20,15 +20,21 @@
 #define getUInt32( A, B ) 	(uint32_t)(A[B+0] << 0) + (A[B+1] << 8) + (A[B+2] << 16) + (A[B+3] << 24)
 
 // Convert from UInt32 to Byte[] in a portable way
-#define putUInt32( A, B, C ) 	A[B+0] = (uint8_t) (C & 0xff);		\
-				A[B+1] = (uint8_t) ((C>>8) & 0xff);	\
-				A[B+2] = (uint8_t) ((C>>16) & 0xff);	\
-				A[B+3] = (uint8_t) ((C>>24) & 0xff)
+#define putUInt32(A, B, C)					\
+do {								\
+	A[B+0] = (uint8_t) (C & 0xff);				\
+	A[B+1] = (uint8_t) ((C>>8) & 0xff);			\
+	A[B+2] = (uint8_t) ((C>>16) & 0xff);			\
+	A[B+3] = (uint8_t) ((C>>24) & 0xff);			\
+} while (0)
 
 // Reset the state to the empty message.
-#define MichaelClear( A ) 	A->L = A->K0; \
-				A->R = A->K1; \
-				A->nBytesInM = 0;
+#define MichaelClear(A)			\
+do {					\
+	A->L = A->K0;			\
+	A->R = A->K1;			\
+	A->nBytesInM = 0;		\
+} while (0)
 
 static
 void MichaelInitializeFunction(struct michel_mic_t *Mic, uint8_t * key)
-- 
2.1.0

[toc] | [next] | [standalone]

#1443830

On Thu, Jul 14, 2016 at 05:01:51PM +0800, Sunbing wrote:
> The formatting of macros definetion in ks7010/michael_mic.c is not
> consistent with the general kernel coding style.
> 
> Fix it by the result of scripts/checkpatch.pl.
> 
> No functional changes.
> 
> Signed-off-by: Sunbing <sunbing.linux@gmail.com>

We need a "real" and "full" name here, please.

Also, work on your subject: line to match other patches that have been
accepted into this driver.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1445057

On Jul 15, 2016, at 8:32, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Thu, Jul 14, 2016 at 05:01:51PM +0800, Sunbing wrote:
>> The formatting of macros definetion in ks7010/michael_mic.c is not
>> consistent with the general kernel coding style.
>> 
>> Fix it by the result of scripts/checkpatch.pl.
>> 
>> No functional changes.
>> 
>> Signed-off-by: Sunbing <sunbing.linux@gmail.com>
> 
> We need a "real" and "full" name here, please.
> 
> Also, work on your subject: line to match other patches that have been
> accepted into this driver.
> 
> thanks,
> 
> greg k-h


Thanks for your reply.

1. I will change a real full subject name  : 
staging: ks7010: Change macros definition coding style in michael_mic.c

2. Do you mean a patch fix macros definition error was accepted ?
where can I find it ? I can’t find it in git and mail-list. 


Regards.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web