Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443292 > unrolled thread

[PATCH] Bluetooth: Fix l2cap_sock_setsockopt() with optname BT_RCVMTU

Back to article view | Back to linux.kernel

Contents

  [PATCH] Bluetooth: Fix l2cap_sock_setsockopt() with optname BT_RCVMTU Amadeusz Sławiński   <amadeusz.slawinski@tieto.com> - 2016-07-14 11:00 +0200
    Re: [PATCH] Bluetooth: Fix l2cap_sock_setsockopt() with optname BT_RCVMTU Marcel Holtmann <marcel@holtmann.org> - 2016-07-14 11:10 +0200

#1443292 — [PATCH] Bluetooth: Fix l2cap_sock_setsockopt() with optname BT_RCVMTU

When we retrieve imtu value from userspace we should use 16 bit pointer
cast instead of 32 as it's defined that way in headers. Fixes setsockopt
calls on big-endian platforms.

Signed-off-by: Amadeusz Sławiński <amadeusz.slawinski@tieto.com>
---
 net/bluetooth/l2cap_sock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index 388ee8b..1842141 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -927,7 +927,7 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname,
 			break;
 		}
 
-		if (get_user(opt, (u32 __user *) optval)) {
+		if (get_user(opt, (u16 __user *) optval)) {
 			err = -EFAULT;
 			break;
 		}
-- 
1.9.1

[toc] | [next] | [standalone]

#1443305

Hi Amadeusz,

> When we retrieve imtu value from userspace we should use 16 bit pointer
> cast instead of 32 as it's defined that way in headers. Fixes setsockopt
> calls on big-endian platforms.
> 
> Signed-off-by: Amadeusz Sławiński <amadeusz.slawinski@tieto.com>
> ---
> net/bluetooth/l2cap_sock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web