Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1443097 > unrolled thread
| Started by | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| First post | 2016-07-14 08:20 +0200 |
| Last post | 2016-07-18 17:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report Andrew Duggan <aduggan@synaptics.com> - 2016-07-14 08:20 +0200
Re: [PATCH v3 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-18 17:00 +0200
| From | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| Date | 2016-07-14 08:20 +0200 |
| Subject | [PATCH v3 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report |
| Message-ID | <rUIa6-5Pz-27@gated-at.bofh.it> |
The size of relative data in F11 is already defined by RMI_F11_REL_BYTES. Use the define in rmi_f11_rel_pos_report() to be consistent. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Reviewed-by: Nick Dyer <nick@shmanahar.org> --- This is the same as the v2 version. drivers/input/rmi4/rmi_f11.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index 3fda75b..cce82a1 100644 --- a/drivers/input/rmi4/rmi_f11.c +++ b/drivers/input/rmi4/rmi_f11.c @@ -530,8 +530,8 @@ static void rmi_f11_rel_pos_report(struct f11_data *f11, u8 n_finger) struct f11_2d_data *data = &f11->data; s8 x, y; - x = data->rel_pos[n_finger * 2]; - y = data->rel_pos[n_finger * 2 + 1]; + x = data->rel_pos[n_finger * RMI_F11_REL_BYTES]; + y = data->rel_pos[n_finger * RMI_F11_REL_BYTES + 1]; rmi_2d_sensor_rel_report(sensor, x, y); } -- 2.5.0
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-07-18 17:00 +0200 |
| Subject | Re: [PATCH v3 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report |
| Message-ID | <rWibv-7xJ-23@gated-at.bofh.it> |
| In reply to | #1443097 |
On Jul 13 2016 or thereabouts, Andrew Duggan wrote: > The size of relative data in F11 is already defined by RMI_F11_REL_BYTES. > Use the define in rmi_f11_rel_pos_report() to be consistent. > > Signed-off-by: Andrew Duggan <aduggan@synaptics.com> > Reviewed-by: Nick Dyer <nick@shmanahar.org> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > This is the same as the v2 version. > > drivers/input/rmi4/rmi_f11.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index 3fda75b..cce82a1 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -530,8 +530,8 @@ static void rmi_f11_rel_pos_report(struct f11_data *f11, u8 n_finger) > struct f11_2d_data *data = &f11->data; > s8 x, y; > > - x = data->rel_pos[n_finger * 2]; > - y = data->rel_pos[n_finger * 2 + 1]; > + x = data->rel_pos[n_finger * RMI_F11_REL_BYTES]; > + y = data->rel_pos[n_finger * RMI_F11_REL_BYTES + 1]; > > rmi_2d_sensor_rel_report(sensor, x, y); > } > -- > 2.5.0 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web