Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440297 > unrolled thread
| Started by | "Veeraiyan Chidambaram (RBEI/ECF32)" <Veeraiyan.Chidambaram@in.bosch.com> |
|---|---|
| First post | 2016-07-11 09:00 +0200 |
| Last post | 2016-07-12 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] cdrom: support read sub-channel command in LBA format "Veeraiyan Chidambaram (RBEI/ECF32)" <Veeraiyan.Chidambaram@in.bosch.com> - 2016-07-11 09:00 +0200
Re: [PATCH] cdrom: support read sub-channel command in LBA format Jens Axboe <axboe@kernel.dk> - 2016-07-12 17:30 +0200
| From | "Veeraiyan Chidambaram (RBEI/ECF32)" <Veeraiyan.Chidambaram@in.bosch.com> |
|---|---|
| Date | 2016-07-11 09:00 +0200 |
| Subject | [PATCH] cdrom: support read sub-channel command in LBA format |
| Message-ID | <rTDma-3uz-21@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hello Jens, In CDROM Linux driver code, "Read Sub channel" format is hard coded with CDROM_MSF format only in the function cdrom_read_subchannel() and mmc_ioctl_cdrom_subchannel() in cdrom.c. Hence, irrespective of "Read Sub channel" command with CDROM_LBA/CDROM_MSF format, the reported Response which is in MSF format was considered as LBA in user space application. Now the behavior is changed in such way that IOCTL returns either CDROM_MSF or CDROM_LBA format per user request. Please find the fix patch attached. Best regards Veeraiyan Chidambaram RBEI/ECF Tel. +91(422)676-4495
[toc] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2016-07-12 17:30 +0200 |
| Message-ID | <rU7Nf-6JY-3@gated-at.bofh.it> |
| In reply to | #1440297 |
On 07/10/2016 11:49 PM, Veeraiyan Chidambaram (RBEI/ECF32) wrote: > Hello Jens, > > In CDROM Linux driver code, "Read Sub channel" format is hard coded > with CDROM_MSF format only in the function cdrom_read_subchannel() and > mmc_ioctl_cdrom_subchannel() in cdrom.c. Hence, irrespective of > "Read Sub channel" command with CDROM_LBA/CDROM_MSF format, the > reported Response which is in MSF format was considered as LBA in user > space application. Now the behavior is changed in such way that > IOCTL returns either CDROM_MSF or CDROM_LBA format per user request. > Please find the fix patch attached. Applied for 4.8, thanks. -- Jens Axboe
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web