Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440676 > unrolled thread

Re: [PATCH 1/2] soc: samsung: Change type of PMU configuration register value to u32

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] soc: samsung: Change type of PMU configuration  register value to u32 Abhilash Kesavan <kesavan.abhilash@gmail.com> - 2016-07-11 16:50 +0200
    Re: [PATCH 1/2] soc: samsung: Change type of PMU configuration  register value to u32 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-12 11:00 +0200

#1440676 — Re: [PATCH 1/2] soc: samsung: Change type of PMU configuration register value to u32

Hi Krzysztof,

On Wed, Jul 6, 2016 at 8:47 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On Tue, Jul 5, 2016 at 10:28 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote:
>> Exynos7 has certain PMU registers that needs to be configured with
>> u32 values.
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> ---
>>  drivers/soc/samsung/exynos-pmu.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h
>> index a469e36..1bdc506 100644
>> --- a/drivers/soc/samsung/exynos-pmu.h
>> +++ b/drivers/soc/samsung/exynos-pmu.h
>> @@ -18,7 +18,7 @@
>>
>>  struct exynos_pmu_conf {
>>         unsigned int offset;
>> -       u8 val[NUM_SYS_POWERDOWN];
>> +       unsigned int val[NUM_SYS_POWERDOWN];
>
> You mentioned u32 but I see unsigned int here. This should be u32.
Will change.
>
> BTW, none of your emails reached my samsung inbox. I got them only
> from the lists. Please investigate why this couldn't be delivered to
> samsung.com address.

Not quite sure why that happened even after I added you as a
recipient. I'll be posting some patches soon, let's see if the same
occurs again or if it was a one-off case.

Regards,
Abhilash
>
> Best regards,
> Krzysztof

[toc] | [next] | [standalone]

#1441153

On 07/11/2016 04:44 PM, Abhilash Kesavan wrote:
> Hi Krzysztof,
> 
> On Wed, Jul 6, 2016 at 8:47 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On Tue, Jul 5, 2016 at 10:28 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote:
>>> Exynos7 has certain PMU registers that needs to be configured with
>>> u32 values.
>>>
>>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>>> ---
>>>  drivers/soc/samsung/exynos-pmu.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h
>>> index a469e36..1bdc506 100644
>>> --- a/drivers/soc/samsung/exynos-pmu.h
>>> +++ b/drivers/soc/samsung/exynos-pmu.h
>>> @@ -18,7 +18,7 @@
>>>
>>>  struct exynos_pmu_conf {
>>>         unsigned int offset;
>>> -       u8 val[NUM_SYS_POWERDOWN];
>>> +       unsigned int val[NUM_SYS_POWERDOWN];
>>
>> You mentioned u32 but I see unsigned int here. This should be u32.
> Will change.
>>
>> BTW, none of your emails reached my samsung inbox. I got them only
>> from the lists. Please investigate why this couldn't be delivered to
>> samsung.com address.
> 
> Not quite sure why that happened even after I added you as a
> recipient. I'll be posting some patches soon, let's see if the same
> occurs again or if it was a one-off case.

No problem with these mails so either this was one time issue or it was
caused by git-send-email and company's SMTP server.

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web