Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1436112 > unrolled thread

Update the maximum depth of C-state from 6 to 9

Started by"baolex.ni" <baolex.ni@intel.com>
First post2016-07-04 04:00 +0200
Last post2016-07-11 04:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  Update the maximum depth of C-state from 6 to 9 "baolex.ni" <baolex.ni@intel.com> - 2016-07-04 04:00 +0200
    Re: Update the maximum depth of C-state from 6 to 9 Jonathan Corbet <corbet@lwn.net> - 2016-07-11 00:40 +0200
      Re: Update the maximum depth of C-state from 6 to 9 "baolex.ni" <baolex.ni@intel.com> - 2016-07-11 04:00 +0200

#1436112 — Update the maximum depth of C-state from 6 to 9

From"baolex.ni" <baolex.ni@intel.com>
Date2016-07-04 04:00 +0200
SubjectUpdate the maximum depth of C-state from 6 to 9
Message-ID<rR1kZ-7Ok-3@gated-at.bofh.it>
Currently, CPUIDLE_STATE_MAX has been defined as 10 in the cpuidle head file,
and max_cstate = CPUIDLE_STATE_MAX – 1, so 9 is the right maximum depth of C-state.
This change is reflected in one place of the kernel-param file,
but not in the other place where I suggest changing.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 Documentation/kernel-parameters.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 82b42c9..a863737 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1661,7 +1661,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
 
 	intel_idle.max_cstate=	[KNL,HW,ACPI,X86]
 			0	disables intel_idle and fall back on acpi_idle.
-			1 to 6	specify maximum depth of C-state.
+			1 to 9	specify maximum depth of C-state.
 
 	intel_pstate=  [X86]
 		       disable
-- 
2.8.3

[toc] | [next] | [standalone]


#1440180

FromJonathan Corbet <corbet@lwn.net>
Date2016-07-11 00:40 +0200
Message-ID<rTvyi-6Vm-39@gated-at.bofh.it>
In reply to#1436112
On Mon, 4 Jul 2016 09:55:10 +0800
"baolex.ni" <baolex.ni@intel.com> wrote:

> Currently, CPUIDLE_STATE_MAX has been defined as 10 in the cpuidle head file,
> and max_cstate = CPUIDLE_STATE_MAX – 1, so 9 is the right maximum depth of C-state.
> This change is reflected in one place of the kernel-param file,
> but not in the other place where I suggest changing.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

So why are there two signoffs on a single-line patch?  Which one of you
is the actual author?

Thanks,

jon

[toc] | [prev] | [next] | [standalone]


#1440200

From"baolex.ni" <baolex.ni@intel.com>
Date2016-07-11 04:00 +0200
Message-ID<rTyFP-nq-1@gated-at.bofh.it>
In reply to#1440180

[Multipart message — attachments visible in raw view] — view raw

Hi Jon,

This patch is an old one, we have corrected some minor issues on the newer one.
Please only review the newest version from my last mail with this subject
"[PATCH] ACPI: Update the maximum depth of C-state from 6 to 9".
And I also attached it to this mail.

Thanks,
Baole

On 7/11/2016 6:37 AM, Jonathan Corbet wrote:
> On Mon, 4 Jul 2016 09:55:10 +0800
> "baolex.ni" <baolex.ni@intel.com> wrote:
> 
>> Currently, CPUIDLE_STATE_MAX has been defined as 10 in the cpuidle head file,
>> and max_cstate = CPUIDLE_STATE_MAX – 1, so 9 is the right maximum depth of C-state.
>> This change is reflected in one place of the kernel-param file,
>> but not in the other place where I suggest changing.
>>
>> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
>> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> 
> So why are there two signoffs on a single-line patch?  Which one of you
> is the actual author?
> 
> Thanks,
> 
> jon
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web