Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440093 > unrolled thread
| Started by | Nicolai Stange <nicstange@gmail.com> |
|---|---|
| First post | 2016-07-10 14:30 +0200 |
| Last post | 2016-07-10 14:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/4] arch, x86, tsc deadline clockevent dev: reduce frequency roundoff error Nicolai Stange <nicstange@gmail.com> - 2016-07-10 14:30 +0200
| From | Nicolai Stange <nicstange@gmail.com> |
|---|---|
| Date | 2016-07-10 14:30 +0200 |
| Subject | [PATCH 1/4] arch, x86, tsc deadline clockevent dev: reduce frequency roundoff error |
| Message-ID | <rTm1X-AD-1@gated-at.bofh.it> |
In setup_APIC_timer(), the registered clockevent device's frequency is calculated by first dividing tsc_khz by TSC_DIVISOR and multiplying it with 1000 afterwards. The multiplication with 1000 is done for converting from kHz to Hz and the division by TSC_DIVISOR is carried out in order to make sure that the final result fits into an u32. However, with the order given in this calculation, the roundoff error introduced by the division gets magnified by a factor of 1000 by the following multiplication. Increase the accuracy by reversing the order of the division and multiplication. In order not to overflow during this calculation, cast temporarily to u64. Signed-off-by: Nicolai Stange <nicstange@gmail.com> --- arch/x86/kernel/apic/apic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 89a5bce..dce654c 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -563,7 +563,8 @@ static void setup_APIC_timer(void) CLOCK_EVT_FEAT_DUMMY); levt->set_next_event = lapic_next_deadline; clockevents_config_and_register(levt, - (tsc_khz / TSC_DIVISOR) * 1000, + (u32)(((u64)tsc_khz * 1000) / + TSC_DIVISOR), 0xF, ~0UL); } else clockevents_register_device(levt); -- 2.9.0
Back to top | Article view | linux.kernel
csiph-web