Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439942 > unrolled thread
| Started by | tip-bot for Paolo Bonzini <tipbot@zytor.com> |
|---|---|
| First post | 2016-07-09 14:00 +0200 |
| Last post | 2016-07-10 13:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[tip:x86/asm] x86/entry: Inline enter_from_user_mode() tip-bot for Paolo Bonzini <tipbot@zytor.com> - 2016-07-09 14:00 +0200
Re: [tip:x86/asm] x86/entry: Inline enter_from_user_mode() Borislav Petkov <bp@alien8.de> - 2016-07-09 15:40 +0200
Re: [tip:x86/asm] x86/entry: Inline enter_from_user_mode() Ingo Molnar <mingo@kernel.org> - 2016-07-10 13:40 +0200
| From | tip-bot for Paolo Bonzini <tipbot@zytor.com> |
|---|---|
| Date | 2016-07-09 14:00 +0200 |
| Subject | [tip:x86/asm] x86/entry: Inline enter_from_user_mode() |
| Message-ID | <rSZ5o-2vZ-15@gated-at.bofh.it> |
Commit-ID: eec4b1227db153ca16f8f5f285d01fefdce05438
Gitweb: http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
Author: Paolo Bonzini <pbonzini@redhat.com>
AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 9 Jul 2016 10:44:02 +0200
x86/entry: Inline enter_from_user_mode()
This matches what is already done for prepare_exit_to_usermode(),
and saves about 60 clock cycles (4% speedup) with the benchmark
in the previous commit message.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kvm@vger.kernel.org
Link: http://lkml.kernel.org/r/1466434712-31440-3-git-send-email-pbonzini@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/entry/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
index 618bc61..9e1e27d 100644
--- a/arch/x86/entry/common.c
+++ b/arch/x86/entry/common.c
@@ -40,7 +40,7 @@ static struct thread_info *pt_regs_to_thread_info(struct pt_regs *regs)
#ifdef CONFIG_CONTEXT_TRACKING
/* Called on entry from user mode with IRQs off. */
-__visible void enter_from_user_mode(void)
+__visible inline void enter_from_user_mode(void)
{
CT_WARN_ON(ct_state() != CONTEXT_USER);
user_exit_irqoff();
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-07-09 15:40 +0200 |
| Message-ID | <rT0E9-3Ev-7@gated-at.bofh.it> |
| In reply to | #1439942 |
tip-bot for Paolo Bonzini <tipbot@zytor.com> wrote: >Commit-ID: eec4b1227db153ca16f8f5f285d01fefdce05438 >Gitweb: >http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438 >Author: Paolo Bonzini <pbonzini@redhat.com> >AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200 >Committer: Ingo Molnar <mingo@kernel.org> >CommitDate: Sat, 9 Jul 2016 10:44:02 +0200 > >x86/entry: Inline enter_from_user_mode() > >This matches what is already done for prepare_exit_to_usermode(), >and saves about 60 clock cycles (4% speedup) with the benchmark >in the previous commit message. > >Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >Reviewed-by: Rik van Riel <riel@redhat.com> >Reviewed-by: Andy Lutomirski <luto@kernel.org> >Reviewed-by: Rik van Riel <riel@redhat.com> >Reviewed-by: Andy Lutomirski <luto@kernel.org> >Reviewed-by: Rik van Riel <riel@redhat.com> >Reviewed-by: Andy Lutomirski <luto@kernel.org> >Reviewed-by: Rik van Riel <riel@redhat.com> >Reviewed-by: Andy Lutomirski <luto@kernel.org> >Acked-by: Paolo Bonzini <pbonzini@redhat.com> Woohaa, if that amount of review doesn't get this patch upstream I don't know what will ;-))))) -- Sent from a small device: formatting sucks and brevity is inevitable.
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-07-10 13:40 +0200 |
| Message-ID | <rTlfz-8sJ-7@gated-at.bofh.it> |
| In reply to | #1439949 |
* Borislav Petkov <bp@alien8.de> wrote: > tip-bot for Paolo Bonzini <tipbot@zytor.com> wrote: > > >Commit-ID: eec4b1227db153ca16f8f5f285d01fefdce05438 > >Gitweb: > >http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438 > >Author: Paolo Bonzini <pbonzini@redhat.com> > >AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200 > >Committer: Ingo Molnar <mingo@kernel.org> > >CommitDate: Sat, 9 Jul 2016 10:44:02 +0200 > > > >x86/entry: Inline enter_from_user_mode() > > > >This matches what is already done for prepare_exit_to_usermode(), > >and saves about 60 clock cycles (4% speedup) with the benchmark > >in the previous commit message. > > > >Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > >Reviewed-by: Rik van Riel <riel@redhat.com> > >Reviewed-by: Andy Lutomirski <luto@kernel.org> > >Reviewed-by: Rik van Riel <riel@redhat.com> > >Reviewed-by: Andy Lutomirski <luto@kernel.org> > >Reviewed-by: Rik van Riel <riel@redhat.com> > >Reviewed-by: Andy Lutomirski <luto@kernel.org> > >Reviewed-by: Rik van Riel <riel@redhat.com> > >Reviewed-by: Andy Lutomirski <luto@kernel.org> > >Acked-by: Paolo Bonzini <pbonzini@redhat.com> > > Woohaa, if that amount of review doesn't get this patch upstream I don't know what will ;-))))) Gah, that's a script gone bad - fixed! Thanks, Ingo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web