Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440961 > unrolled thread

[PATCH 2/3] befs: in memory free_node_ptr and max_size never read

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/3] befs: in memory free_node_ptr and max_size never read Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-12 01:10 +0200

#1440961 — [PATCH 2/3] befs: in memory free_node_ptr and max_size never read

The only place the values of free_node_ptr and max_size are read is in
befs_dump_index_entry(), which both times it is called, it is passed the on
disk superblock. Removing assignment of unused values.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Hi,

Noticed this when reading befs' btree code.

Thanks,
Luis

 fs/befs/btree.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/befs/btree.c b/fs/befs/btree.c
index 3995d58..2b5b635 100644
--- a/fs/befs/btree.c
+++ b/fs/befs/btree.c
@@ -156,8 +156,6 @@ befs_bt_read_super(struct super_block *sb, const befs_data_stream *ds,
 	sup->max_depth = fs32_to_cpu(sb, od_sup->max_depth);
 	sup->data_type = fs32_to_cpu(sb, od_sup->data_type);
 	sup->root_node_ptr = fs64_to_cpu(sb, od_sup->root_node_ptr);
-	sup->free_node_ptr = fs64_to_cpu(sb, od_sup->free_node_ptr);
-	sup->max_size = fs64_to_cpu(sb, od_sup->max_size);
 
 	brelse(bh);
 	if (sup->magic != BEFS_BTREE_MAGIC) {
-- 
2.5.3

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web