Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440925 > unrolled thread

[PATCH] rtc: isl12057: remove unused variables

Back to article view | Back to linux.kernel

Contents

  [PATCH] rtc: isl12057: remove unused variables Arnd Bergmann <arnd@arndb.de> - 2016-07-11 23:50 +0200
    Re: [PATCH] rtc: isl12057: remove unused variables Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-12 09:20 +0200

#1440925 — [PATCH] rtc: isl12057: remove unused variables

A cleanup patch introduced a harmless warning about now unused local variables:

drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm':
drivers/rtc/rtc-isl12057.c:249:26: error: unused variable 'alarm_secs' [-Werror=unused-variable]
  unsigned long rtc_secs, alarm_secs;
                          ^~~~~~~~~~
drivers/rtc/rtc-isl12057.c:249:16: error: unused variable 'rtc_secs' [-Werror=unused-variable]
  unsigned long rtc_secs, alarm_secs;
                ^~~~~~~~
drivers/rtc/rtc-isl12057.c:248:18: error: unused variable 'rtc_tm' [-Werror=unused-variable]
  struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
                  ^~~~~~

This removes the variables to shut up those warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm")
---
 drivers/rtc/rtc-isl12057.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c
index e0245fc6205e..0e7f0f52bfe4 100644
--- a/drivers/rtc/rtc-isl12057.c
+++ b/drivers/rtc/rtc-isl12057.c
@@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable)
 static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
 {
 	struct isl12057_rtc_data *data = dev_get_drvdata(dev);
-	struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
-	unsigned long rtc_secs, alarm_secs;
+	struct rtc_time *alarm_tm = &alarm->time;
 	u8 regs[ISL12057_A1_SEC_LEN];
 	unsigned int ir;
 	int ret;
-- 
2.9.0

[toc] | [next] | [standalone]

#1441102

Hi Arnd,

On 11/07/2016 at 23:42:57 +0200, Arnd Bergmann wrote :
> A cleanup patch introduced a harmless warning about now unused local variables:
> 
> drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm':
> drivers/rtc/rtc-isl12057.c:249:26: error: unused variable 'alarm_secs' [-Werror=unused-variable]
>   unsigned long rtc_secs, alarm_secs;
>                           ^~~~~~~~~~
> drivers/rtc/rtc-isl12057.c:249:16: error: unused variable 'rtc_secs' [-Werror=unused-variable]
>   unsigned long rtc_secs, alarm_secs;
>                 ^~~~~~~~
> drivers/rtc/rtc-isl12057.c:248:18: error: unused variable 'rtc_tm' [-Werror=unused-variable]
>   struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
>                   ^~~~~~
> 
> This removes the variables to shut up those warnings.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm")

I actually fixed it up in the patch yesterday.

> ---
>  drivers/rtc/rtc-isl12057.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c
> index e0245fc6205e..0e7f0f52bfe4 100644
> --- a/drivers/rtc/rtc-isl12057.c
> +++ b/drivers/rtc/rtc-isl12057.c
> @@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable)
>  static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
>  {
>  	struct isl12057_rtc_data *data = dev_get_drvdata(dev);
> -	struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
> -	unsigned long rtc_secs, alarm_secs;
> +	struct rtc_time *alarm_tm = &alarm->time;
>  	u8 regs[ISL12057_A1_SEC_LEN];
>  	unsigned int ir;
>  	int ret;
> -- 
> 2.9.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web