Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440942 > unrolled thread
| Started by | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| First post | 2016-07-12 00:20 +0200 |
| Last post | 2016-07-19 22:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI / PCI: make pci_slot explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-12 00:20 +0200
Re: [PATCH] ACPI / PCI: make pci_slot explicitly non-modular "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-19 22:10 +0200
| From | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| Date | 2016-07-12 00:20 +0200 |
| Subject | [PATCH] ACPI / PCI: make pci_slot explicitly non-modular |
| Message-ID | <rTRIt-4Dg-7@gated-at.bofh.it> |
The Kconfig for this file is:
drivers/acpi/Kconfig:config ACPI_PCI_SLOT
drivers/acpi/Kconfig: bool "PCI slot detection driver"
...and so it is not built as a module. Hence including module.h
and everything that comes with it just for the no-op MODULE_LICENSE
and friends is rather heavy handed.
The license/author info is found at the top of the file, so we
just remove the MODULE_LICENSE etc and the include of module.h
We delete the DRIVER_VERSION macro as well since it is unused.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/acpi/pci_slot.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
index 1236fb04a708..f62c68e24317 100644
--- a/drivers/acpi/pci_slot.c
+++ b/drivers/acpi/pci_slot.c
@@ -25,7 +25,6 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h>
-#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/types.h>
@@ -37,13 +36,6 @@
static int check_sta_before_sun;
-#define DRIVER_VERSION "0.1"
-#define DRIVER_AUTHOR "Alex Chiang <achiang@hp.com>"
-#define DRIVER_DESC "ACPI PCI Slot Detection Driver"
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
-
#define _COMPONENT ACPI_PCI_COMPONENT
ACPI_MODULE_NAME("pci_slot");
--
2.8.4
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-07-19 22:10 +0200 |
| Message-ID | <rWJv4-5v-5@gated-at.bofh.it> |
| In reply to | #1440942 |
On Monday, July 11, 2016 06:17:23 PM Paul Gortmaker wrote: > The Kconfig for this file is: > > drivers/acpi/Kconfig:config ACPI_PCI_SLOT > drivers/acpi/Kconfig: bool "PCI slot detection driver" > > ...and so it is not built as a module. Hence including module.h > and everything that comes with it just for the no-op MODULE_LICENSE > and friends is rather heavy handed. > > The license/author info is found at the top of the file, so we > just remove the MODULE_LICENSE etc and the include of module.h > > We delete the DRIVER_VERSION macro as well since it is unused. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-acpi@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Applied, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web