Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440817 > unrolled thread

Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency  table index Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-11 20:50 +0200
    Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-16 03:00 +0200

#1440817 — Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index

On 30-06-16, 11:53, Akshay Adiga wrote:
> Refactoring code to use frequency table index instead of pstate_id.
> This abstraction will make the code independent of the pstate values.
> 
> - No functional changes
> - The highest frequency is at frequency table index 0 and the frequency
>   decreases as the index increases.
> - Macros pstates_to_idx() and idx_to_pstate() can be used for conversion
>   between pstate_id and index.
> - powernv_pstate_info now contains frequency table index to min, max and
>   nominal frequency (instead of pstate_ids)
> - global_pstate_info new stores index values instead pstate ids.
> - variables renamed as *_idx which now store index instead of pstate
> 
> Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
> Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> ---
> Changes from v1:
>   - changed macro names from get_pstate()/ get_index() to 
> idx_to_pstate()/ pstate_to_idx()
>   - Renamed variables that store index instead of pstate_id to *_idx
>   - Retained previous printk's 
> 
> v1 : http://marc.info/?l=linux-pm&m=146677701501225&w=1
> 
>  drivers/cpufreq/powernv-cpufreq.c | 177 ++++++++++++++++++++++----------------
>  1 file changed, 102 insertions(+), 75 deletions(-)

Haven't done in-depth review, but I trust that Gautham has done it :)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

[toc] | [next] | [standalone]

#1444709 — Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index

On Monday, July 11, 2016 11:47:53 AM Viresh Kumar wrote:
> On 30-06-16, 11:53, Akshay Adiga wrote:
> > Refactoring code to use frequency table index instead of pstate_id.
> > This abstraction will make the code independent of the pstate values.
> > 
> > - No functional changes
> > - The highest frequency is at frequency table index 0 and the frequency
> >   decreases as the index increases.
> > - Macros pstates_to_idx() and idx_to_pstate() can be used for conversion
> >   between pstate_id and index.
> > - powernv_pstate_info now contains frequency table index to min, max and
> >   nominal frequency (instead of pstate_ids)
> > - global_pstate_info new stores index values instead pstate ids.
> > - variables renamed as *_idx which now store index instead of pstate
> > 
> > Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
> > Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> > ---
> > Changes from v1:
> >   - changed macro names from get_pstate()/ get_index() to 
> > idx_to_pstate()/ pstate_to_idx()
> >   - Renamed variables that store index instead of pstate_id to *_idx
> >   - Retained previous printk's 
> > 
> > v1 : http://marc.info/?l=linux-pm&m=146677701501225&w=1
> > 
> >  drivers/cpufreq/powernv-cpufreq.c | 177 ++++++++++++++++++++++----------------
> >  1 file changed, 102 insertions(+), 75 deletions(-)
> 
> Haven't done in-depth review, but I trust that Gautham has done it :)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Patch applied, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web