Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440677 > unrolled thread
| Started by | Toralf Förster <toralf.foerster@gmx.de> |
|---|---|
| First post | 2016-07-11 16:50 +0200 |
| Last post | 2016-07-12 07:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: crypto: ux500 - memmove the right size Toralf Förster <toralf.foerster@gmx.de> - 2016-07-11 16:50 +0200
Re: crypto: ux500 - memmove the right size Herbert Xu <herbert@gondor.apana.org.au> - 2016-07-12 07:00 +0200
| From | Toralf Förster <toralf.foerster@gmx.de> |
|---|---|
| Date | 2016-07-11 16:50 +0200 |
| Subject | Re: crypto: ux500 - memmove the right size |
| Message-ID | <rTKH1-8jQ-45@gated-at.bofh.it> |
While reading the comment to 19ced623d :
" The hash buffer is really HASH_BLOCK_SIZE bytes, someone
must have thought that memmove takes n*u32 words by mistake.
Tests work as good/bad as before after this patch.
"
I was just curious why the tests doesn't fail now and since when the bug were in the code.
The answer to the later is simple - the bug is there since the beginning of that file.
What's do you think about the first question ?
--
Toralf
PGP: C4EACDDE 0076E94E, OTR: 420E74C8 30246EE7
[toc] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-07-12 07:00 +0200 |
| Message-ID | <rTXXz-7V-3@gated-at.bofh.it> |
| In reply to | #1440677 |
On Mon, Jul 11, 2016 at 04:40:34PM +0200, Toralf Förster wrote: > While reading the comment to 19ced623d : > > " The hash buffer is really HASH_BLOCK_SIZE bytes, someone > must have thought that memmove takes n*u32 words by mistake. > Tests work as good/bad as before after this patch. > " > > I was just curious why the tests doesn't fail now and since when the bug were in the code. > The answer to the later is simple - the bug is there since the beginning of that file. > What's do you think about the first question ? The tests do/can not cover every possible execution path. Of course if you can write a simple vector/test that covers this case that would be very nice. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web