Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440289 > unrolled thread

Re: [PATCH v5 2/3] pwm: iproc: Add support for Broadcom iproc pwm controller

Back to article view | Back to linux.kernel

Contents

  Re: [PATCH v5 2/3] pwm: iproc: Add support for Broadcom iproc pwm controller Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> - 2016-07-11 09:00 +0200
    Re: [PATCH v5 2/3] pwm: iproc: Add support for Broadcom iproc pwm  controller Thierry Reding <thierry.reding@gmail.com> - 2016-07-11 12:40 +0200

#1440289 — Re: [PATCH v5 2/3] pwm: iproc: Add support for Broadcom iproc pwm controller

Hi Thierry,

On Fri, Jul 8, 2016 at 8:46 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Jul 05, 2016 at 02:00:25AM -0400, Yendapally Reddy Dhananjaya Reddy wrote:
>> Add support for the PWM controller present in Broadcom's iProc
>> family of SoCs.It has been tested on the  Northstar+ bcm958625HR board.
>>
>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
>> ---
>>  drivers/pwm/Kconfig         |  10 ++
>>  drivers/pwm/Makefile        |   1 +
>>  drivers/pwm/pwm-bcm-iproc.c | 268 ++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 279 insertions(+)
>>  create mode 100644 drivers/pwm/pwm-bcm-iproc.c
>
> I've applied this, but I had to make a couple of changes for coding
> style and to squash compiler warnings. Please check the PWM tree's
> for-next branch to see if it still works for you.
>

  Thanks. It is working fine for me. A small change is required here,
NSEC_PER_SEC
instead of USEC_PER_SEC in two places.

Thanks
Dhananjay


> Thierry

[toc] | [next] | [standalone]

#1440453 — Re: [PATCH v5 2/3] pwm: iproc: Add support for Broadcom iproc pwm controller

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jul 11, 2016 at 12:22:38PM +0530, Yendapally Reddy Dhananjaya Reddy wrote:
> Hi Thierry,
> 
> On Fri, Jul 8, 2016 at 8:46 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Tue, Jul 05, 2016 at 02:00:25AM -0400, Yendapally Reddy Dhananjaya Reddy wrote:
> >> Add support for the PWM controller present in Broadcom's iProc
> >> family of SoCs.It has been tested on the  Northstar+ bcm958625HR board.
> >>
> >> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
> >> ---
> >>  drivers/pwm/Kconfig         |  10 ++
> >>  drivers/pwm/Makefile        |   1 +
> >>  drivers/pwm/pwm-bcm-iproc.c | 268 ++++++++++++++++++++++++++++++++++++++++++++
> >>  3 files changed, 279 insertions(+)
> >>  create mode 100644 drivers/pwm/pwm-bcm-iproc.c
> >
> > I've applied this, but I had to make a couple of changes for coding
> > style and to squash compiler warnings. Please check the PWM tree's
> > for-next branch to see if it still works for you.
> >
> 
>   Thanks. It is working fine for me. A small change is required here,
> NSEC_PER_SEC
> instead of USEC_PER_SEC in two places.

Ah yes, I had mixed those up when converting from literal to symbolic.
Should be fixed now.

Thanks,
Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web