Groups > linux.kernel > #1440199 > unrolled thread

linux-next: build failure after merge of the pm tree

Started by	Stephen Rothwell <sfr@canb.auug.org.au>
First post	2016-07-11 03:50 +0200
Last post	2016-07-11 15:00 +0200
Articles	4 — 3 participants

Back to article view | Back to linux.kernel

  linux-next: build failure after merge of the pm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-11 03:50 +0200
    Re: linux-next: build failure after merge of the pm tree Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-11 06:50 +0200
      Re: linux-next: build failure after merge of the pm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-11 07:40 +0200
        Re: linux-next: build failure after merge of the pm tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-11 15:00 +0200

#1440199 — linux-next: build failure after merge of the pm tree

From	Stephen Rothwell <sfr@canb.auug.org.au>
Date	2016-07-11 03:50 +0200
Subject	linux-next: build failure after merge of the pm tree
Message-ID	<rTyw9-kh-5@gated-at.bofh.it>

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
ERROR: "config_item_put" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
ERROR: "config_item_init_type_name" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!

... and many more ...

Presumably (maybe?) caused by commit

  0bf54fcd9504 ("ACPI: add support for configfs")

though it is not obvious why this should be a problem.

I have used the version of the pm tree from next-20160708 for today.
-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1440243

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Date	2016-07-11 06:50 +0200
Message-ID	<rTBkl-2fP-5@gated-at.bofh.it>
In reply to	#1440199

On Mon, Jul 11, 2016 at 11:46:53AM +1000, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> ERROR: "config_item_put" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> ERROR: "config_item_init_type_name" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> 
> ... and many more ...
> 
> Presumably (maybe?) caused by commit
> 
>   0bf54fcd9504 ("ACPI: add support for configfs")
> 
> though it is not obvious why this should be a problem.

Looks like it is the module name (configfs.o) that confuses modpost or
linker. The below patch fixes it for me.

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] ACPI: Rename configfs.c to acpi_configfs.c to prevent link error

If we compile ACPI configfs.c as module it will confuse the linker as it
hides symbols from the actual configfs:

Kernel: arch/x86/boot/bzImage is ready  (#1236)
  MODPOST 5739 modules
ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
...

Prevent these by renaming the file to acpi_configfs.c instead.

Reported-by: Scott Lawson <scott.lawson@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/acpi/Makefile                        | 2 +-
 drivers/acpi/{configfs.c => acpi_configfs.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/acpi/{configfs.c => acpi_configfs.c} (100%)

diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 1dc2173ad8d0..f72a83df1cf3 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -99,6 +99,6 @@ obj-$(CONFIG_ACPI_EXTLOG)	+= acpi_extlog.o
 obj-$(CONFIG_PMIC_OPREGION)	+= pmic/intel_pmic.o
 obj-$(CONFIG_CRC_PMIC_OPREGION) += pmic/intel_pmic_crc.o
 obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
-obj-$(CONFIG_ACPI_CONFIGFS)	+= configfs.o
+obj-$(CONFIG_ACPI_CONFIGFS)	+= acpi_configfs.o
 
 video-objs			+= acpi_video.o video_detect.o
diff --git a/drivers/acpi/configfs.c b/drivers/acpi/acpi_configfs.c
similarity index 100%
rename from drivers/acpi/configfs.c
rename to drivers/acpi/acpi_configfs.c
-- 
2.8.1

[toc] | [prev] | [next] | [standalone]

#1440258

From	Stephen Rothwell <sfr@canb.auug.org.au>
Date	2016-07-11 07:40 +0200
Message-ID	<rTC6J-2Oh-13@gated-at.bofh.it>
In reply to	#1440243

Hi Mika,

On Mon, 11 Jul 2016 07:48:17 +0300 Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
> Looks like it is the module name (configfs.o) that confuses modpost or
> linker. The below patch fixes it for me.

That makes sense.  Thanks.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1440606

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date	2016-07-11 15:00 +0200
Message-ID	<rTIYy-79b-5@gated-at.bofh.it>
In reply to	#1440258

On Monday, July 11, 2016 03:29:55 PM Stephen Rothwell wrote:
> Hi Mika,
> 
> On Mon, 11 Jul 2016 07:48:17 +0300 Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> >
> > Looks like it is the module name (configfs.o) that confuses modpost or
> > linker. The below patch fixes it for me.
> 
> That makes sense.  Thanks.

OK, I'll apply the Mika's patch.

Thanks,
Rafael

[toc] | [prev] | [standalone]

csiph-web

linux-next: build failure after merge of the pm tree

Contents

#1440199 — linux-next: build failure after merge of the pm tree

#1440243

#1440258

#1440606