Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1438142 > unrolled thread
| Started by | Wei Jiangang <weijg.fnst@cn.fujitsu.com> |
|---|---|
| First post | 2016-07-07 05:40 +0200 |
| Last post | 2016-07-07 17:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] xen/apic: Update the comment for apic_id_mask Wei Jiangang <weijg.fnst@cn.fujitsu.com> - 2016-07-07 05:40 +0200
Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-07 17:30 +0200
Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-07-07 17:40 +0200
| From | Wei Jiangang <weijg.fnst@cn.fujitsu.com> |
|---|---|
| Date | 2016-07-07 05:40 +0200 |
| Subject | [PATCH] xen/apic: Update the comment for apic_id_mask |
| Message-ID | <rS8kp-1om-1@gated-at.bofh.it> |
verify_local_APIC() had been removed by
commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
so apic_id_mask isn't used by it.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
arch/x86/xen/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
index db52a7fafcc2..9cbb1f48381b 100644
--- a/arch/x86/xen/apic.c
+++ b/arch/x86/xen/apic.c
@@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
.get_apic_id = xen_get_apic_id,
.set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
- .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
+ .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
.cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
--
1.9.3
[toc] | [next] | [standalone]
| From | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> |
|---|---|
| Date | 2016-07-07 17:30 +0200 |
| Subject | Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask |
| Message-ID | <rSjpv-jj-17@gated-at.bofh.it> |
| In reply to | #1438142 |
On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
> verify_local_APIC() had been removed by
> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
> so apic_id_mask isn't used by it.
CC-ing the proper maintainers.
>
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> arch/x86/xen/apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
> index db52a7fafcc2..9cbb1f48381b 100644
> --- a/arch/x86/xen/apic.c
> +++ b/arch/x86/xen/apic.c
> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>
> .get_apic_id = xen_get_apic_id,
> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
>
> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
>
> --
> 1.9.3
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
[toc] | [prev] | [next] | [standalone]
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Date | 2016-07-07 17:40 +0200 |
| Subject | Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask |
| Message-ID | <rSjzc-nu-17@gated-at.bofh.it> |
| In reply to | #1438676 |
On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
>> verify_local_APIC() had been removed by
>> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
>> so apic_id_mask isn't used by it.
Is anyone actually using this field? It looks like 4399c03c6780 removed
the only user.
-boris
> CC-ing the proper maintainers.
>> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
>> ---
>> arch/x86/xen/apic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
>> index db52a7fafcc2..9cbb1f48381b 100644
>> --- a/arch/x86/xen/apic.c
>> +++ b/arch/x86/xen/apic.c
>> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>>
>> .get_apic_id = xen_get_apic_id,
>> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
>> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
>> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
>>
>> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
>>
>> --
>> 1.9.3
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web