Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438556 > unrolled thread

[PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks

Back to article view | Back to linux.kernel

Contents

  [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks Andi Shyti <andi.shyti@samsung.com> - 2016-07-07 14:20 +0200
    Re: [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-07-07 15:20 +0200
      Re: [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-07-07 17:30 +0200

#1438556 — [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks

Hi,

I managed to bring some confusion on these two patches, but
finally I managed to find the right solution (which is similar to
the patch version 2).

The real issue was hidden in the spi bus as reported in the
following patch:

  https://lkml.org/lkml/2016/7/7/81

This patch in principle replaces the clock_ignore_unused flags in
for the spi and enables the spi3 that in the tm2(e) board will be
connected to the IR remote controller.

Changelog:

V1 -> V2
 - the "sclk_spi3" doesn't need to be enabled in boot time as it
  is handled by the spi driver itself.

 - use the CLK_IS_CRITICAL flag for the ioclk

V2 -> V3
 - some more tests has confirmed taht "sclk_spi1,3" need to be
   enabled as critical!

 - added Chanwoo's review in the second commit.

V3 -> V4
 - patch V3 was wrong, back to patch v2.

 - reworded the commit of patch no. 1

Thanks,
Andi

Andi Shyti (2):
  clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks
  clk: exynos5433: enable sclk_ioclk for SPI3

 drivers/clk/samsung/clk-exynos5433.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.8.1

[toc] | [next] | [standalone]

#1438612

On 07/07/2016 02:13 PM, Andi Shyti wrote:
> Andi Shyti (2):
>   clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks
>   clk: exynos5433: enable sclk_ioclk for SPI3

Applied both patches, thanks.

[toc] | [prev] | [next] | [standalone]

#1438673

On 07/07/2016 03:18 PM, Sylwester Nawrocki wrote:
> On 07/07/2016 02:13 PM, Andi Shyti wrote:
>> > Andi Shyti (2):
>> >   clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks
>> >   clk: exynos5433: enable sclk_ioclk for SPI3
>
> Applied both patches, thanks.

Apologies for the confusion, I had to drop these patches for reasons
explained in the other thread. We just need to simply drop
CLK_IGNORE_UNUSED flags and get the driver controlling clocks which
belong to the peripheral IP block.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web