Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438404 > unrolled thread

[PATCH] nvme-loop: add configfs dependency

Back to article view | Back to linux.kernel

Contents

  [PATCH] nvme-loop: add configfs dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-07 11:00 +0200
    Re: [PATCH] nvme-loop: add configfs dependency Jens Axboe <axboe@kernel.dk> - 2016-07-07 16:40 +0200

#1438404 — [PATCH] nvme-loop: add configfs dependency

CONFIG_NVME_TARGET has a correct CONFIG_CONFIGFS_FS dependency, but the
newly added NVME_TARGET_LOOP is missing this, resulting in a link
failure:

drivers/nvme/built-in.o: In function `nvmet_init_configfs':
loop.c:(.init.text+0x2a0): undefined reference to `config_group_init'
loop.c:(.init.text+0x2c0): undefined reference to `config_group_init_type_name'
loop.c:(.init.text+0x318): undefined reference to `configfs_register_subsystem'
drivers/nvme/built-in.o: In function `nvmet_exit_configfs':
loop.c:(.exit.text+0x9c): undefined reference to `configfs_unregister_subsystem'

This adds the same dependency here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver")
---
 drivers/nvme/target/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
index b77ce4350695..6bbd7890c3ad 100644
--- a/drivers/nvme/target/Kconfig
+++ b/drivers/nvme/target/Kconfig
@@ -16,6 +16,7 @@ config NVME_TARGET
 config NVME_TARGET_LOOP
 	tristate "NVMe loopback device support"
 	depends on BLK_DEV_NVME
+	depends on CONFIGFS_FS
 	select NVME_TARGET
 	select NVME_FABRICS
 	select SG_POOL
-- 
2.9.0

[toc] | [next] | [standalone]

#1438649

On 07/07/2016 03:01 AM, Arnd Bergmann wrote:
> CONFIG_NVME_TARGET has a correct CONFIG_CONFIGFS_FS dependency, but the
> newly added NVME_TARGET_LOOP is missing this, resulting in a link
> failure:
>
> drivers/nvme/built-in.o: In function `nvmet_init_configfs':
> loop.c:(.init.text+0x2a0): undefined reference to `config_group_init'
> loop.c:(.init.text+0x2c0): undefined reference to `config_group_init_type_name'
> loop.c:(.init.text+0x318): undefined reference to `configfs_register_subsystem'
> drivers/nvme/built-in.o: In function `nvmet_exit_configfs':
> loop.c:(.exit.text+0x9c): undefined reference to `configfs_unregister_subsystem'
>
> This adds the same dependency here.

Thanks Arnd, applied.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web