Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437687 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-07-06 14:50 +0200 |
| Last post | 2016-07-07 15:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-06 14:50 +0200
Re: [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency Eric Anholt <eric@anholt.net> - 2016-07-06 20:00 +0200
Re: [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-07 15:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-06 14:50 +0200 |
| Subject | [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency |
| Message-ID | <rRUr7-OO-3@gated-at.bofh.it> |
We get a harmless warning if the RASPBERRYPI_POWER driver is enabled without CONFIG_OF during compile testing: warning: RASPBERRYPI_POWER selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can replace the 'select' with a dependency. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/soc/bcm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig index 97156aeed286..a39b0d58ddd0 100644 --- a/drivers/soc/bcm/Kconfig +++ b/drivers/soc/bcm/Kconfig @@ -2,10 +2,9 @@ menu "Broadcom SoC drivers" config RASPBERRYPI_POWER bool "Raspberry Pi power domain driver" - depends on ARCH_BCM2835 || COMPILE_TEST + depends on ARCH_BCM2835 || (COMPILE_TEST && OF) depends on RASPBERRYPI_FIRMWARE=y select PM_GENERIC_DOMAINS if PM - select PM_GENERIC_DOMAINS_OF if PM help This enables support for the RPi power domains which can be enabled or disabled via the RPi firmware. -- 2.9.0
[toc] | [next] | [standalone]
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2016-07-06 20:00 +0200 |
| Message-ID | <rRZh8-3OH-25@gated-at.bofh.it> |
| In reply to | #1437687 |
[Multipart message — attachments visible in raw view] — view raw
Arnd Bergmann <arnd@arndb.de> writes: > We get a harmless warning if the RASPBERRYPI_POWER driver is enabled without > CONFIG_OF during compile testing: > > warning: RASPBERRYPI_POWER selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can > replace the 'select' with a dependency. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Eric Anholt <eric@anholt.net> I'm guessing you'll take this patch directly.
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-07 15:00 +0200 |
| Message-ID | <rSh4l-71b-29@gated-at.bofh.it> |
| In reply to | #1437887 |
On Wednesday, July 6, 2016 10:54:19 AM CEST Eric Anholt wrote: > Arnd Bergmann <arnd@arndb.de> writes: > > > We get a harmless warning if the RASPBERRYPI_POWER driver is enabled without > > CONFIG_OF during compile testing: > > > > warning: RASPBERRYPI_POWER selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > > > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can > > replace the 'select' with a dependency. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Eric Anholt <eric@anholt.net> > > I'm guessing you'll take this patch directly. > Applied into next/drivers, thanks for the Ack Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web