Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437431 > unrolled thread
| Started by | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| First post | 2016-07-06 07:40 +0200 |
| Last post | 2016-07-07 09:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] clocksource: cadence_ttc: fix a return value in case of error Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-07-06 07:40 +0200
Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-07-06 18:10 +0200
Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-07 09:50 +0200
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| Date | 2016-07-06 07:40 +0200 |
| Subject | [PATCH] clocksource: cadence_ttc: fix a return value in case of error |
| Message-ID | <rRNIZ-563-9@gated-at.bofh.it> |
IS_ERR and PTR_ERR should use the same variable, clk_ce in this case.
Fixes: 4de1eb07c47f (Convert init function to return error)
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/clocksource/cadence_ttc_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/cadence_ttc_timer.c b/drivers/clocksource/cadence_ttc_timer.c
index 388a77b..fbfbdec 100644
--- a/drivers/clocksource/cadence_ttc_timer.c
+++ b/drivers/clocksource/cadence_ttc_timer.c
@@ -523,7 +523,7 @@ static int __init ttc_timer_init(struct device_node *timer)
clk_ce = of_clk_get(timer, clksel);
if (IS_ERR(clk_ce)) {
pr_err("ERROR: timer input clock not found\n");
- return PTR_ERR(clk_cs);
+ return PTR_ERR(clk_ce);
}
ret = ttc_setup_clocksource(clk_cs, timer_baseaddr, timer_width);
--
2.7.4
[toc] | [next] | [standalone]
| From | Sören Brinkmann <soren.brinkmann@xilinx.com> |
|---|---|
| Date | 2016-07-06 18:10 +0200 |
| Subject | Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error |
| Message-ID | <rRXyF-2Wq-19@gated-at.bofh.it> |
| In reply to | #1437431 |
On Wed, 2016-07-06 at 07:35:23 +0200, Christophe JAILLET wrote: > IS_ERR and PTR_ERR should use the same variable, clk_ce in this case. > > Fixes: 4de1eb07c47f (Convert init function to return error) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> Sören
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2016-07-07 09:50 +0200 |
| Subject | Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error |
| Message-ID | <rScem-3Vx-17@gated-at.bofh.it> |
| In reply to | #1437431 |
On Wed, Jul 06, 2016 at 07:35:23AM +0200, Christophe JAILLET wrote: > IS_ERR and PTR_ERR should use the same variable, clk_ce in this case. > > Fixes: 4de1eb07c47f (Convert init function to return error) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied, thanks. -- Daniel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web