Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433100 > unrolled thread
| Started by | Martin Kepplinger <martink@posteo.de> |
|---|---|
| First post | 2016-06-28 18:30 +0200 |
| Last post | 2016-07-09 14:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes Martin Kepplinger <martink@posteo.de> - 2016-06-28 18:30 +0200
Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-08 23:10 +0200
Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes Martin Kepplinger <martink@posteo.de> - 2016-07-09 14:10 +0200
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2016-06-28 18:30 +0200 |
| Subject | Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes |
| Message-ID | <rP43E-XT-27@gated-at.bofh.it> |
Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov:
> Hi Martin,
>
> On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote:
>> static int pegasus_reset_resume(struct usb_interface *intf)
>> {
>> + struct pegasus *pegasus = usb_get_intfdata(intf);
>> +
>> + if (pegasus->dev->users)
>> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE);
>> +
>> return pegasus_resume(intf);
>
> Hmm, we need to take input mutex when using pegasus->dev->users, how
> about the version below instead?
>
> Thanks.
>
Sorry for the delay, give me a few more days to test and confirm this or
come up with a final patch.
thanks
martin
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-07-08 23:10 +0200 |
| Message-ID | <rSLc5-1Ig-3@gated-at.bofh.it> |
| In reply to | #1433100 |
On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote:
> Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov:
> > Hi Martin,
> >
> > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote:
> >> static int pegasus_reset_resume(struct usb_interface *intf)
> >> {
> >> + struct pegasus *pegasus = usb_get_intfdata(intf);
> >> +
> >> + if (pegasus->dev->users)
> >> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE);
> >> +
> >> return pegasus_resume(intf);
> >
> > Hmm, we need to take input mutex when using pegasus->dev->users, how
> > about the version below instead?
> >
> > Thanks.
> >
>
> Sorry for the delay, give me a few more days to test and confirm this or
> come up with a final patch.
Martin, did you have time to try out this version of the patch?
Thanks!
--
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2016-07-09 14:10 +0200 |
| Message-ID | <rSZf3-2OR-7@gated-at.bofh.it> |
| In reply to | #1439795 |
Am 2016-07-08 um 23:08 schrieb Dmitry Torokhov:
> On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote:
>> Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov:
>>> Hi Martin,
>>>
>>> On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote:
>>>> static int pegasus_reset_resume(struct usb_interface *intf)
>>>> {
>>>> + struct pegasus *pegasus = usb_get_intfdata(intf);
>>>> +
>>>> + if (pegasus->dev->users)
>>>> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE);
>>>> +
>>>> return pegasus_resume(intf);
>>>
>>> Hmm, we need to take input mutex when using pegasus->dev->users, how
>>> about the version below instead?
>>>
>>> Thanks.
>>>
>>
>> Sorry for the delay, give me a few more days to test and confirm this or
>> come up with a final patch.
>
> Martin, did you have time to try out this version of the patch?
>
> Thanks!
>
This patch doesn't seem to work as is. Holidays get in the way, but you
can expect a working patch(set) next week.
martin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web