Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439928 > unrolled thread
| Started by | Randy Li <ayaka@soulik.info> |
|---|---|
| First post | 2016-07-09 11:30 +0200 |
| Last post | 2016-07-11 07:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Randy Li <ayaka@soulik.info> - 2016-07-09 11:30 +0200
[PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Randy Li <ayaka@soulik.info> - 2016-07-09 11:30 +0200
Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-11 07:50 +0200
Re: [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-11 07:50 +0200
| From | Randy Li <ayaka@soulik.info> |
|---|---|
| Date | 2016-07-09 11:30 +0200 |
| Subject | [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work |
| Message-ID | <rSWKd-14B-5@gated-at.bofh.it> |
The 8792f7772f4f40ffc68bad5f28311205584b734d would just make those platform using rtc core from exynos3250 work but have a huge effect on those platforms using the rtc core from s3c6410. These patches would fix this problem. Randy Li (3): Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" rtc: s3c: add device data for samsung,exynos3250-rtc ARM: dts: exynos: correct the rtc compatible value for exynos5 arch/arm/boot/dts/exynos3250.dtsi | 2 +- arch/arm/boot/dts/exynos5.dtsi | 2 +- drivers/rtc/rtc-s3c.c | 15 +++++++++++++-- 3 files changed, 15 insertions(+), 4 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Randy Li <ayaka@soulik.info> |
|---|---|
| Date | 2016-07-09 11:30 +0200 |
| Subject | [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" |
| Message-ID | <rSWKd-14B-9@gated-at.bofh.it> |
| In reply to | #1439928 |
This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d.
The s3c6410 rtc don't use rtc_src property, that property is designed
for Exynos5250 and Exynos5440. The problem reported in the commit
I mentioned should be fixed in the other way.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
drivers/rtc/rtc-s3c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index d01ad7e..5dc18ca 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = {
static struct s3c_rtc_data const s3c6410_rtc_data = {
.max_user_freq = 32768,
- .needs_src_clk = true,
.irq_handler = s3c6410_rtc_irq,
.set_freq = s3c6410_rtc_setfreq,
.enable_tick = s3c6410_rtc_enable_tick,
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-07-11 07:50 +0200 |
| Subject | Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" |
| Message-ID | <rTCgp-2Rz-13@gated-at.bofh.it> |
| In reply to | #1439929 |
On 07/09/2016 11:23 AM, Randy Li wrote:
> This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d.
> The s3c6410 rtc don't use rtc_src property, that property is designed
> for Exynos5250 and Exynos5440. The problem reported in the commit
> I mentioned should be fixed in the other way.
... so you break in this commit all the newer platforms because the
rtc_src clock won't be enabled.
Does not look right.
Best regards,
Krzysztof
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
> drivers/rtc/rtc-s3c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index d01ad7e..5dc18ca 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = {
>
> static struct s3c_rtc_data const s3c6410_rtc_data = {
> .max_user_freq = 32768,
> - .needs_src_clk = true,
> .irq_handler = s3c6410_rtc_irq,
> .set_freq = s3c6410_rtc_setfreq,
> .enable_tick = s3c6410_rtc_enable_tick,
>
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-07-11 07:50 +0200 |
| Message-ID | <rTCgp-2Rz-11@gated-at.bofh.it> |
| In reply to | #1439928 |
On 07/09/2016 11:23 AM, Randy Li wrote: > The 8792f7772f4f40ffc68bad5f28311205584b734d would just make those > platform using rtc core from exynos3250 work but have a huge > effect on those platforms using the rtc core from s3c6410. > These patches would fix this problem. > Which problem? What huge effect? On which platforms? You didn't describe it... Your change breaks the ABI and is not compatible with current bindings documentation. Best regards, Krzysztof > Randy Li (3): > Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" > rtc: s3c: add device data for samsung,exynos3250-rtc > ARM: dts: exynos: correct the rtc compatible value for exynos5 > > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos5.dtsi | 2 +- > drivers/rtc/rtc-s3c.c | 15 +++++++++++++-- > 3 files changed, 15 insertions(+), 4 deletions(-) >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web