Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439906 > unrolled thread
| Started by | Xunlei Pang <xlpang@redhat.com> |
|---|---|
| First post | 2016-07-09 10:00 +0200 |
| Last post | 2016-07-12 17:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle() Xunlei Pang <xlpang@redhat.com> - 2016-07-09 10:00 +0200
Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle() Konstantin Khlebnikov <koct9i@gmail.com> - 2016-07-09 10:20 +0200
Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle() Peter Zijlstra <peterz@infradead.org> - 2016-07-12 17:30 +0200
| From | Xunlei Pang <xlpang@redhat.com> |
|---|---|
| Date | 2016-07-09 10:00 +0200 |
| Subject | [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle() |
| Message-ID | <rSVl7-8qY-3@gated-at.bofh.it> |
Should update "cfs_rq->throttled_clock_task" other than pcfs_rq's. Signed-off-by: Xunlei Pang <xlpang@redhat.com> --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 4088eed..039de34 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu) pcfs_rq = tg->parent->cfs_rq[cpu]; cfs_rq->throttle_count = pcfs_rq->throttle_count; - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); } /* conditionally throttle active cfs_rq's from put_prev_entity() */ -- 1.8.3.1
[toc] | [next] | [standalone]
| From | Konstantin Khlebnikov <koct9i@gmail.com> |
|---|---|
| Date | 2016-07-09 10:20 +0200 |
| Message-ID | <rSVEu-mL-11@gated-at.bofh.it> |
| In reply to | #1439906 |
On Sat, Jul 9, 2016 at 10:54 AM, Xunlei Pang <xlpang@redhat.com> wrote: > Should update "cfs_rq->throttled_clock_task" other than pcfs_rq's. > > Signed-off-by: Xunlei Pang <xlpang@redhat.com> Ack > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 4088eed..039de34 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu) > pcfs_rq = tg->parent->cfs_rq[cpu]; > > cfs_rq->throttle_count = pcfs_rq->throttle_count; > - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); > + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); > } > > /* conditionally throttle active cfs_rq's from put_prev_entity() */ > -- > 1.8.3.1 >
[toc] | [prev] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-07-12 17:30 +0200 |
| Message-ID | <rU7Ng-6JY-17@gated-at.bofh.it> |
| In reply to | #1439906 |
On Sat, Jul 09, 2016 at 03:54:22PM +0800, Xunlei Pang wrote: > +++ b/kernel/sched/fair.c > @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu) > pcfs_rq = tg->parent->cfs_rq[cpu]; > > cfs_rq->throttle_count = pcfs_rq->throttle_count; > - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); > + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); Ah indeed, thanks! > } > > /* conditionally throttle active cfs_rq's from put_prev_entity() */ > -- > 1.8.3.1 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web