Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436941 > unrolled thread
| Started by | Samuele Baisi <ciccio87@gmail.com> |
|---|---|
| First post | 2016-07-05 13:40 +0200 |
| Last post | 2016-07-08 21:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. Samuele Baisi <ciccio87@gmail.com> - 2016-07-05 13:40 +0200
Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-08 20:20 +0200
Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. Samuele Baisi <ciccio87@gmail.com> - 2016-07-08 21:40 +0200
Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-08 21:50 +0200
| From | Samuele Baisi <ciccio87@gmail.com> |
|---|---|
| Date | 2016-07-05 13:40 +0200 |
| Subject | [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. |
| Message-ID | <rRwRQ-2bm-15@gated-at.bofh.it> |
Removed a blankline after an opening bracket.
Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index eb7e252..ae39663 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
int j;
for (i = 0; i < TTY_MAX_COUNT; i++) {
-
gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
if (!gdm)
return -ENOMEM;
--
2.8.1
[toc] | [next] | [standalone]
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2016-07-08 20:20 +0200 |
| Message-ID | <rSIxz-8ma-3@gated-at.bofh.it> |
| In reply to | #1436941 |
On 05/07/16 12:33, Samuele Baisi wrote:
> Removed a blankline after an opening bracket.
>
> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..ae39663 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
> int j;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> -
> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
> if (!gdm)
> return -ENOMEM;
>
Patch applies cleanly and removes the checkpath issue.
Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Samuele,
It is a good idea to include the issue you are solving in the commit
message, in this case it would be:
Removed a blankline after an opening bracket.
CHECK: Blank lines aren't necessary after an open brace '{'
#228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
+ for (i = 0; i < TTY_MAX_COUNT; i++) {
+
Signed-off-by:
---
Thanks :)
Luis
[toc] | [prev] | [next] | [standalone]
| From | Samuele Baisi <ciccio87@gmail.com> |
|---|---|
| Date | 2016-07-08 21:40 +0200 |
| Subject | Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. |
| Message-ID | <rSJMZ-CK-1@gated-at.bofh.it> |
| In reply to | #1439731 |
Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt
<luisbg@osg.samsung.com> ha scritto:
> On 05/07/16 12:33, Samuele Baisi wrote:
>> Removed a blankline after an opening bracket.
>>
>> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
>> ---
>> drivers/staging/gdm724x/gdm_tty.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm724x/gdm_tty.c
>> b/drivers/staging/gdm724x/gdm_tty.c
>> index eb7e252..ae39663 100644
>> --- a/drivers/staging/gdm724x/gdm_tty.c
>> +++ b/drivers/staging/gdm724x/gdm_tty.c
>> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev
>> *tty_dev, struct device *device)
>> int j;
>>
>> for (i = 0; i < TTY_MAX_COUNT; i++) {
>> -
>> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
>> if (!gdm)
>> return -ENOMEM;
>>
>
> Patch applies cleanly and removes the checkpath issue.
>
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> Samuele,
>
> It is a good idea to include the issue you are solving in the commit
> message, in this case it would be:
>
> Removed a blankline after an opening bracket.
>
> CHECK: Blank lines aren't necessary after an open brace '{'
> #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
> + for (i = 0; i < TTY_MAX_COUNT; i++) {
> +
>
> Signed-off-by:
> ---
>
> Thanks :)
> Luis
Ok, next time I'll try to be more clear.
Thank you very much and best regards.
Samuele
[toc] | [prev] | [next] | [standalone]
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2016-07-08 21:50 +0200 |
| Message-ID | <rSJWG-Gh-13@gated-at.bofh.it> |
| In reply to | #1439761 |
On 08/07/16 20:32, Samuele Baisi wrote:
>
>
> Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt <luisbg@osg.samsung.com> ha scritto:
>> On 05/07/16 12:33, Samuele Baisi wrote:
>>> Removed a blankline after an opening bracket.
>>>
>>> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
>>> ---
>>> drivers/staging/gdm724x/gdm_tty.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
>>> index eb7e252..ae39663 100644
>>> --- a/drivers/staging/gdm724x/gdm_tty.c
>>> +++ b/drivers/staging/gdm724x/gdm_tty.c
>>> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
>>> int j;
>>>
>>> for (i = 0; i < TTY_MAX_COUNT; i++) {
>>> -
>>> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
>>> if (!gdm)
>>> return -ENOMEM;
>>>
>>
>> Patch applies cleanly and removes the checkpath issue.
>>
>> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>>
>> Samuele,
>>
>> It is a good idea to include the issue you are solving in the commit
>> message, in this case it would be:
>>
>> Removed a blankline after an opening bracket.
>>
>> CHECK: Blank lines aren't necessary after an open brace '{'
>> #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
>> + for (i = 0; i < TTY_MAX_COUNT; i++) {
>> +
>>
>> Signed-off-by:
>> ---
>>
>> Thanks :)
>> Luis
>
> Ok, next time I'll try to be more clear.
>
> Thank you very much and best regards.
>
> Samuele
>
No problem Samuele.
Looking forward to more patches from you soon :)
Feel free to CC me in them.
Luis
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web