Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439499 > unrolled thread
| Started by | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| First post | 2016-07-08 16:20 +0200 |
| Last post | 2016-07-08 19:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc_dev structure definition Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-08 16:20 +0200
Re: [PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc_dev structure definition Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-08 19:20 +0200
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2016-07-08 16:20 +0200 |
| Subject | [PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc_dev structure definition |
| Message-ID | <rSENj-5T8-3@gated-at.bofh.it> |
Add missing documentation for s5p_mfc_dev structure definition.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
index 9eb2481..1d06d6a 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
@@ -291,7 +291,9 @@ struct s5p_mfc_priv_buf {
* @warn_start: hardware error code from which warnings start
* @mfc_ops: ops structure holding HW operation function pointers
* @mfc_cmds: cmd structure holding HW commands function pointers
+ * @mfc_regs: structure holding MFC registers
* @fw_ver: loaded firmware sub-version
+ * risc_on: flag indicates RISC is on or off
*
*/
struct s5p_mfc_dev {
--
2.7.4
[toc] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-07-08 19:20 +0200 |
| Subject | Re: [PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc_dev structure definition |
| Message-ID | <rSHBw-7JO-21@gated-at.bofh.it> |
| In reply to | #1439499 |
Hello Shuah,
On 07/08/2016 10:12 AM, Shuah Khan wrote:
> Add missing documentation for s5p_mfc_dev structure definition.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> index 9eb2481..1d06d6a 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> @@ -291,7 +291,9 @@ struct s5p_mfc_priv_buf {
> * @warn_start: hardware error code from which warnings start
> * @mfc_ops: ops structure holding HW operation function pointers
> * @mfc_cmds: cmd structure holding HW commands function pointers
> + * @mfc_regs: structure holding MFC registers
> * @fw_ver: loaded firmware sub-version
> + * risc_on: flag indicates RISC is on or off
> *
> */
> struct s5p_mfc_dev {
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web