Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439457 > unrolled thread
| Started by | Ingo Molnar <mingo@kernel.org> |
|---|---|
| First post | 2016-07-08 15:40 +0200 |
| Last post | 2016-07-08 16:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] x86/asm/entry: Make thunk's restore a local label Ingo Molnar <mingo@kernel.org> - 2016-07-08 15:40 +0200
[PATCH v1.1] x86/asm/entry: Make thunk's restore a local label Borislav Petkov <bp@alien8.de> - 2016-07-08 16:20 +0200
[tip:x86/asm] x86/asm/entry: Make thunk's restore a local label tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-07-08 16:50 +0200
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-07-08 15:40 +0200 |
| Subject | Re: [PATCH] x86/asm/entry: Make thunk's restore a local label |
| Message-ID | <rSEaC-5on-11@gated-at.bofh.it> |
* Borislav Petkov <bp@alien8.de> wrote: > From: Borislav Petkov <bp@suse.de> > > No need to have it appear in objdump output. > > No functionality change. > > Signed-off-by: Borislav Petkov <bp@suse.de> > --- > arch/x86/entry/thunk_64.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S > index 027aec4a74df..7b506f52a92c 100644 > --- a/arch/x86/entry/thunk_64.S > +++ b/arch/x86/entry/thunk_64.S > @@ -33,7 +33,7 @@ > .endif > > call \func > - jmp restore > + jmp .Lrestore Btw., could we make it .L_restore to make it more readable - or does the underscore confuse tooling? Thanks, Ingo
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-07-08 16:20 +0200 |
| Subject | [PATCH v1.1] x86/asm/entry: Make thunk's restore a local label |
| Message-ID | <rSENj-5T8-1@gated-at.bofh.it> |
| In reply to | #1439457 |
On Fri, Jul 08, 2016 at 03:38:51PM +0200, Ingo Molnar wrote:
> Btw., could we make it .L_restore to make it more readable - or does the
> underscore confuse tooling?
Nah, builds fine too.
---
From: Borislav Petkov <bp@suse.de>
Date: Fri, 8 Jul 2016 16:01:48 +0200
Subject: [PATCH v1.1] x86/asm/entry: Make thunk's restore a local label
No need to have it appear in objdump output.
No functionality change.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/entry/thunk_64.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S
index 027aec4a74df..627ecbcb2e62 100644
--- a/arch/x86/entry/thunk_64.S
+++ b/arch/x86/entry/thunk_64.S
@@ -33,7 +33,7 @@
.endif
call \func
- jmp restore
+ jmp .L_restore
_ASM_NOKPROBE(\name)
.endm
@@ -54,7 +54,7 @@
#if defined(CONFIG_TRACE_IRQFLAGS) \
|| defined(CONFIG_DEBUG_LOCK_ALLOC) \
|| defined(CONFIG_PREEMPT)
-restore:
+.L_restore:
popq %r11
popq %r10
popq %r9
@@ -66,5 +66,5 @@ restore:
popq %rdi
popq %rbp
ret
- _ASM_NOKPROBE(restore)
+ _ASM_NOKPROBE(.L_restore)
#endif
--
2.7.3
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Borislav Petkov <tipbot@zytor.com> |
|---|---|
| Date | 2016-07-08 16:50 +0200 |
| Subject | [tip:x86/asm] x86/asm/entry: Make thunk's restore a local label |
| Message-ID | <rSFgm-64x-29@gated-at.bofh.it> |
| In reply to | #1439497 |
Commit-ID: 9a7e7b571826c4399aa639af4a670642d96d935c Gitweb: http://git.kernel.org/tip/9a7e7b571826c4399aa639af4a670642d96d935c Author: Borislav Petkov <bp@suse.de> AuthorDate: Fri, 8 Jul 2016 16:01:48 +0200 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Fri, 8 Jul 2016 16:47:01 +0200 x86/asm/entry: Make thunk's restore a local label No need to have it appear in objdump output. No functionality change. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20160708141016.GH3808@pd.tnic Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/entry/thunk_64.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S index 027aec4..627ecbc 100644 --- a/arch/x86/entry/thunk_64.S +++ b/arch/x86/entry/thunk_64.S @@ -33,7 +33,7 @@ .endif call \func - jmp restore + jmp .L_restore _ASM_NOKPROBE(\name) .endm @@ -54,7 +54,7 @@ #if defined(CONFIG_TRACE_IRQFLAGS) \ || defined(CONFIG_DEBUG_LOCK_ALLOC) \ || defined(CONFIG_PREEMPT) -restore: +.L_restore: popq %r11 popq %r10 popq %r9 @@ -66,5 +66,5 @@ restore: popq %rdi popq %rbp ret - _ASM_NOKPROBE(restore) + _ASM_NOKPROBE(.L_restore) #endif
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web