Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439395 > unrolled thread
| Started by | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| First post | 2016-07-08 14:20 +0200 |
| Last post | 2016-07-08 15:00 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti <andi.shyti@samsung.com> - 2016-07-08 14:20 +0200
Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti <andi.shyti@samsung.com> - 2016-07-08 15:00 +0200
Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-08 15:10 +0200
Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-08 15:00 +0200
| From | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| Date | 2016-07-08 14:20 +0200 |
| Subject | [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible |
| Message-ID | <rSCVc-4Fq-49@gated-at.bofh.it> |
The samsung,exynos5433-spi has some peculiarities that bring the
need of creating a new compatible in the binding.
One of those is the 3-clocks controller management where the spi
is fed with three clocks: "spi", "busclkN" and "ioclk".
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt
index 6dbdeb3..d4294c7 100644
--- a/Documentation/devicetree/bindings/spi/spi-samsung.txt
+++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt
@@ -10,6 +10,7 @@ Required SoC Specific Properties:
- samsung,s3c6410-spi: for s3c6410 platforms
- samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms
- samsung,exynos7-spi: for exynos7 platforms
+ - samsung,exynos5433-spi: for exynos5433 compatible controllers
- reg: physical base address of the controller and length of memory mapped
region.
--
2.8.1
[toc] | [next] | [standalone]
| From | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| Date | 2016-07-08 15:00 +0200 |
| Message-ID | <rSDxT-4TG-3@gated-at.bofh.it> |
| In reply to | #1439395 |
> > > > - reg: physical base address of the controller and length of memory mapped > > region. > > > > Thanks for the patch, nice work. I see that you ignored parts of my > offline comments so I guess you leave that work to others (describe > required clock properties, deprecate exynos7-spi). I'll send the follow > up then. I was actually doing the follow up, I think it's a different concept and therefore goes on a different patch. Andi
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-07-08 15:10 +0200 |
| Message-ID | <rSDHA-5cy-29@gated-at.bofh.it> |
| In reply to | #1439421 |
On 07/08/2016 02:56 PM, Andi Shyti wrote: >>> >>> - reg: physical base address of the controller and length of memory mapped >>> region. >>> >> >> Thanks for the patch, nice work. I see that you ignored parts of my >> offline comments so I guess you leave that work to others (describe >> required clock properties, deprecate exynos7-spi). I'll send the follow >> up then. > > I was actually doing the follow up, I think it's a different > concept and therefore goes on a different patch. Ah.... but the exynos5433-spi compatible is related to three clocks - you even mention it in commit message. BR, Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-07-08 15:00 +0200 |
| Message-ID | <rSDxT-4TG-7@gated-at.bofh.it> |
| In reply to | #1439395 |
On 07/08/2016 02:18 PM, Andi Shyti wrote: > The samsung,exynos5433-spi has some peculiarities that bring the > need of creating a new compatible in the binding. That is not accurate. This for both: exynos5433 and exynos7. > > One of those is the 3-clocks controller management where the spi > is fed with three clocks: "spi", "busclkN" and "ioclk". > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt > index 6dbdeb3..d4294c7 100644 > --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt > +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt > @@ -10,6 +10,7 @@ Required SoC Specific Properties: > - samsung,s3c6410-spi: for s3c6410 platforms > - samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms > - samsung,exynos7-spi: for exynos7 platforms > + - samsung,exynos5433-spi: for exynos5433 compatible controllers As I wrote offline, proper order (alpha-numerical), so 5 before 7. > > - reg: physical base address of the controller and length of memory mapped > region. > Thanks for the patch, nice work. I see that you ignored parts of my offline comments so I guess you leave that work to others (describe required clock properties, deprecate exynos7-spi). I'll send the follow up then. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web