Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1438040 > unrolled thread
| Started by | Joseph Salisbury <joseph.salisbury@canonical.com> |
|---|---|
| First post | 2016-07-07 03:00 +0200 |
| Last post | 2016-07-07 03:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-07-07 03:00 +0200
Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-07-07 03:10 +0200
Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Greg KH <gregkh@linuxfoundation.org> - 2016-07-07 03:10 +0200
| From | Joseph Salisbury <joseph.salisbury@canonical.com> |
|---|---|
| Date | 2016-07-07 03:00 +0200 |
| Subject | [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan |
| Message-ID | <rS5Pz-83V-5@gated-at.bofh.it> |
BugLink: http://bugs.launchpad.net/bugs/1498667
As reported in BugLink, this device has an issue with Linux Power
Management so adding a quirk. This quirk was reccomended by Alan Stern:
http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: stable <stable@vger.kernel.org>
---
drivers/usb/core/quirks.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 944a6dc..f028cc5 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x04f3, 0x016f), .driver_info =
USB_QUIRK_DEVICE_QUALIFIER },
+
+ { USB_DEVICE(0x04f3, 0x0381), .driver_info =
+ USB_QUIRK_NO_LPM },
{ USB_DEVICE(0x04f3, 0x21b8), .driver_info =
USB_QUIRK_DEVICE_QUALIFIER },
-
+
/* Roland SC-8820 */
{ USB_DEVICE(0x0582, 0x0007), .driver_info = USB_QUIRK_RESET_RESUME },
--
2.7.4
[toc] | [next] | [standalone]
| From | Joseph Salisbury <joseph.salisbury@canonical.com> |
|---|---|
| Date | 2016-07-07 03:10 +0200 |
| Message-ID | <rS5Zf-8mz-1@gated-at.bofh.it> |
| In reply to | #1438040 |
On 07/06/2016 09:02 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power
>> Management so adding a quirk. This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> Cc: stable <stable@vger.kernel.org>
>> ---
>> drivers/usb/core/quirks.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..f028cc5 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
>>
>> { USB_DEVICE(0x04f3, 0x016f), .driver_info =
>> USB_QUIRK_DEVICE_QUALIFIER },
>> +
>> + { USB_DEVICE(0x04f3, 0x0381), .driver_info =
>> + USB_QUIRK_NO_LPM },
>>
>> { USB_DEVICE(0x04f3, 0x21b8), .driver_info =
>> USB_QUIRK_DEVICE_QUALIFIER },
>> -
>> +
> This is odd, why remove and add a blank line for no reason?
>
That is odd and wasn't intentional, I'll send a V3.
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-07-07 03:10 +0200 |
| Message-ID | <rS5Zf-8mz-3@gated-at.bofh.it> |
| In reply to | #1438040 |
On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1498667
>
> As reported in BugLink, this device has an issue with Linux Power
> Management so adding a quirk. This quirk was reccomended by Alan Stern:
>
> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: stable <stable@vger.kernel.org>
> ---
> drivers/usb/core/quirks.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 944a6dc..f028cc5 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> { USB_DEVICE(0x04f3, 0x016f), .driver_info =
> USB_QUIRK_DEVICE_QUALIFIER },
> +
> + { USB_DEVICE(0x04f3, 0x0381), .driver_info =
> + USB_QUIRK_NO_LPM },
>
> { USB_DEVICE(0x04f3, 0x21b8), .driver_info =
> USB_QUIRK_DEVICE_QUALIFIER },
> -
> +
This is odd, why remove and add a blank line for no reason?
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web