Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436290 > unrolled thread
| Started by | Baoquan He <bhe@redhat.com> |
|---|---|
| First post | 2016-07-04 05:20 +0200 |
| Last post | 2016-07-06 23:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI/init: Correct the comments about acpi_subsystem_init Baoquan He <bhe@redhat.com> - 2016-07-04 05:20 +0200
Re: [PATCH] ACPI/init: Correct the comments about acpi_subsystem_init "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-06 23:30 +0200
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2016-07-04 05:20 +0200 |
| Subject | [PATCH] ACPI/init: Correct the comments about acpi_subsystem_init |
| Message-ID | <rR2Ap-n0-3@gated-at.bofh.it> |
In acpi_subsystem_init, function acpi_enable_subsystem is called to do the real job. However with different flags passed to acpi_enable_subsystem, different code is executed. In acpi_subsystem_init with "~ACPI_NO_ACPI_ENABLE" passed in it will only switch over the platform to the ACPI mode. The rest part of acpi_enable_subsystem is done when acpi_bus_init is called. So the comments above acpi_subsystem_init is not exact, change it here. Signed-off-by: Baoquan He <bhe@redhat.com> --- drivers/acpi/bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 262ca31..eef468d 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -961,8 +961,7 @@ void __init acpi_early_init(void) /** * acpi_subsystem_init - Finalize the early initialization of ACPI. * - * Switch over the platform to the ACPI mode (if possible), initialize the - * handling of ACPI events, install the interrupt and global lock handlers. + * Switch over the platform to the ACPI mode (if possible). * * Doing this too early is generally unsafe, but at the same time it needs to be * done before all things that really depend on ACPI. The right spot appears to -- 2.5.5
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-07-06 23:30 +0200 |
| Message-ID | <rS2yl-64W-1@gated-at.bofh.it> |
| In reply to | #1436290 |
On Monday, July 04, 2016 11:13:59 AM Baoquan He wrote: > In acpi_subsystem_init, function acpi_enable_subsystem is called to do > the real job. However with different flags passed to acpi_enable_subsystem, > different code is executed. In acpi_subsystem_init with "~ACPI_NO_ACPI_ENABLE" > passed in it will only switch over the platform to the ACPI mode. The rest > part of acpi_enable_subsystem is done when acpi_bus_init is called. > > So the comments above acpi_subsystem_init is not exact, change it here. > > Signed-off-by: Baoquan He <bhe@redhat.com> Applied, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web