Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437030 > unrolled thread

[PATCH 0/3] Add STM32F746 MCU pinctrl support

Started byAlexandre TORGUE <alexandre.torgue@st.com>
First post2016-07-05 15:50 +0200
Last post2016-07-05 17:10 +0200
Articles 8 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Add STM32F746 MCU pinctrl support Alexandre TORGUE <alexandre.torgue@st.com> - 2016-07-05 15:50 +0200
    [PATCH 3/3] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings Alexandre TORGUE <alexandre.torgue@st.com> - 2016-07-05 15:50 +0200
      Re: [PATCH 3/3] Documentation: dt: Add new compatible to STM32  pinctrl driver bindings Linus Walleij <linus.walleij@linaro.org> - 2016-07-05 17:10 +0200
    Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-05 16:10 +0200
      Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support Alexandre Torgue <alexandre.torgue@st.com> - 2016-07-06 10:00 +0200
    Re: [PATCH 1/3] includes: dt-bindings: Add STM32F746 pinctrl DT bindings Linus Walleij <linus.walleij@linaro.org> - 2016-07-05 17:00 +0200
      Re: [PATCH 1/3] includes: dt-bindings: Add STM32F746 pinctrl DT  bindings Alexandre Torgue <alexandre.torgue@st.com> - 2016-07-05 17:30 +0200
    Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support Linus Walleij <linus.walleij@linaro.org> - 2016-07-05 17:10 +0200

#1437030 — [PATCH 0/3] Add STM32F746 MCU pinctrl support

FromAlexandre TORGUE <alexandre.torgue@st.com>
Date2016-07-05 15:50 +0200
Subject[PATCH 0/3] Add STM32F746 MCU pinctrl support
Message-ID<rRyTD-3ri-9@gated-at.bofh.it>
This series adds STM32F746 pinctrl and GPIO support, relies on the
generic STM32 pinctrl driver.

Regards

Alex

Alexandre TORGUE (2):
  includes: dt-bindings: Add STM32F746 pinctrl DT bindings
  Documentation: dt: Add new compatible to STM32 pinctrl driver bindings

Maxime Coquelin (1):
  pinctrl: Add STM32F746 MCU support

 .../bindings/pinctrl/st,stm32-pinctrl.txt          |    1 +
 drivers/pinctrl/stm32/Kconfig                      |    6 +
 drivers/pinctrl/stm32/Makefile                     |    2 +
 drivers/pinctrl/stm32/pinctrl-stm32f746.c          | 1693 ++++++++++++++++++++
 include/dt-bindings/pinctrl/stm32f746-pinfunc.h    | 1335 +++++++++++++++
 5 files changed, 3037 insertions(+)
 create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32f746.c
 create mode 100644 include/dt-bindings/pinctrl/stm32f746-pinfunc.h

-- 
1.9.1

[toc] | [next] | [standalone]

#1437035 — [PATCH 3/3] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings

FromAlexandre TORGUE <alexandre.torgue@st.com>
Date2016-07-05 15:50 +0200
Subject[PATCH 3/3] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings
Message-ID<rRyTD-3ri-23@gated-at.bofh.it>
In reply to#1437030
Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
index 7b4800c..587bffb 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
@@ -9,6 +9,7 @@ Pin controller node:
 Required properies:
  - compatible: value should be one of the following:
    (a) "st,stm32f429-pinctrl"
+   (b) "st,stm32f746-pinctrl"
  - #address-cells: The value of this property must be 1
  - #size-cells	: The value of this property must be 1
  - ranges	: defines mapping between pin controller node (parent) to
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1437108 — Re: [PATCH 3/3] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-07-05 17:10 +0200
SubjectRe: [PATCH 3/3] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings
Message-ID<rRA93-4vb-25@gated-at.bofh.it>
In reply to#1437035
On Tue, Jul 5, 2016 at 3:40 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1437047 — Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-07-05 16:10 +0200
SubjectRe: [PATCH 2/3] pinctrl: Add STM32F746 MCU support
Message-ID<rRzd0-3Ok-21@gated-at.bofh.it>
In reply to#1437030
[[PATCH 2/3] pinctrl: Add STM32F746 MCU support] On 05/07/2016 (Tue 15:40) Alexandre TORGUE wrote:

> From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> 
> This patch which adds STM32F746 pinctrl and GPIO support, relies on the
> generic STM32 pinctrl driver.
> 
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
> 
> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
> index 0f28841..4c40dae 100644
> --- a/drivers/pinctrl/stm32/Kconfig
> +++ b/drivers/pinctrl/stm32/Kconfig
> @@ -13,4 +13,10 @@ config PINCTRL_STM32F429
>  	default MACH_STM32F429
>  	select PINCTRL_STM32
>  
> +config PINCTRL_STM32F746
> +	bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746
        ^^^^

> +	depends on OF
> +	default MACH_STM32F746
> +	select PINCTRL_STM32
> +
> +	),
> +};
> +

[...]

> +static const struct of_device_id stm32f746_pctrl_match[] = {
> +	{
> +		.compatible = "st,stm32f746-pinctrl",
> +		.data = &stm32f746_match_data,
> +	},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, stm32f746_pctrl_match);
  ^^^^^^^^^^^^^^^^^^^^

> +
> +static struct platform_driver stm32f746_pinctrl_driver = {
> +	.probe = stm32_pctl_probe,
> +	.driver = {
> +		.name = "stm32f746-pinctrl",
> +		.of_match_table = stm32f746_pctrl_match,
> +	},
> +};
> +
> +static int __init stm32f746_pinctrl_init(void)
> +{
> +	return platform_driver_register(&stm32f746_pinctrl_driver);
> +}
> +
> +module_init(stm32f746_pinctrl_init);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("STM32F746 Pinctrl Driver");
> +MODULE_AUTHOR("Maxime Coquelin <mcoquelin.stm32@gmail.com>");

...and here as well.  Please don't use modular support functions and
infrastructure for code that is only built-in.  Either make sure it can
be modular and use a tristate Kconfig, or delete all the MODULE_<tags>
and use device_initcall() to register the driver.

Thanks,
Paul.
--

> -- 
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]

#1437519 — Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support

FromAlexandre Torgue <alexandre.torgue@st.com>
Date2016-07-06 10:00 +0200
SubjectRe: [PATCH 2/3] pinctrl: Add STM32F746 MCU support
Message-ID<rRPUu-6nj-5@gated-at.bofh.it>
In reply to#1437047
Hi Paul,

On 07/05/2016 04:02 PM, Paul Gortmaker wrote:
> [[PATCH 2/3] pinctrl: Add STM32F746 MCU support] On 05/07/2016 (Tue 15:40) Alexandre TORGUE wrote:
>
>> From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>>
>> This patch which adds STM32F746 pinctrl and GPIO support, relies on the
>> generic STM32 pinctrl driver.
>>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
>> index 0f28841..4c40dae 100644
>> --- a/drivers/pinctrl/stm32/Kconfig
>> +++ b/drivers/pinctrl/stm32/Kconfig
>> @@ -13,4 +13,10 @@ config PINCTRL_STM32F429
>>   	default MACH_STM32F429
>>   	select PINCTRL_STM32
>>
>> +config PINCTRL_STM32F746
>> +	bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746
>          ^^^^
>
>> +	depends on OF
>> +	default MACH_STM32F746
>> +	select PINCTRL_STM32
>> +
>> +	),
>> +};
>> +
>
> [...]
>
>> +static const struct of_device_id stm32f746_pctrl_match[] = {
>> +	{
>> +		.compatible = "st,stm32f746-pinctrl",
>> +		.data = &stm32f746_match_data,
>> +	},
>> +	{ }
>> +};
>> +MODULE_DEVICE_TABLE(of, stm32f746_pctrl_match);
>    ^^^^^^^^^^^^^^^^^^^^
>
>> +
>> +static struct platform_driver stm32f746_pinctrl_driver = {
>> +	.probe = stm32_pctl_probe,
>> +	.driver = {
>> +		.name = "stm32f746-pinctrl",
>> +		.of_match_table = stm32f746_pctrl_match,
>> +	},
>> +};
>> +
>> +static int __init stm32f746_pinctrl_init(void)
>> +{
>> +	return platform_driver_register(&stm32f746_pinctrl_driver);
>> +}
>> +
>> +module_init(stm32f746_pinctrl_init);
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_DESCRIPTION("STM32F746 Pinctrl Driver");
>> +MODULE_AUTHOR("Maxime Coquelin <mcoquelin.stm32@gmail.com>");
>
> ...and here as well.  Please don't use modular support functions and
> infrastructure for code that is only built-in.  Either make sure it can
> be modular and use a tristate Kconfig, or delete all the MODULE_<tags>
> and use device_initcall() to register the driver.

Thanks for remark. I will send a v2 removing modular stuff.

Regards

Alex

>
> Thanks,
> Paul.
> --
>
>> --
>> 1.9.1
>>

[toc] | [prev] | [next] | [standalone]

#1437100 — Re: [PATCH 1/3] includes: dt-bindings: Add STM32F746 pinctrl DT bindings

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-07-05 17:00 +0200
SubjectRe: [PATCH 1/3] includes: dt-bindings: Add STM32F746 pinctrl DT bindings
Message-ID<rRzZn-4bX-13@gated-at.bofh.it>
In reply to#1437030
On Tue, Jul 5, 2016 at 3:40 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

The patch was a bit liberal with newlines so I cut some whitespace
while applying.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1437118 — Re: [PATCH 1/3] includes: dt-bindings: Add STM32F746 pinctrl DT bindings

FromAlexandre Torgue <alexandre.torgue@st.com>
Date2016-07-05 17:30 +0200
SubjectRe: [PATCH 1/3] includes: dt-bindings: Add STM32F746 pinctrl DT bindings
Message-ID<rRAsp-4Ci-1@gated-at.bofh.it>
In reply to#1437100
Hi Linus,

On 07/05/2016 04:59 PM, Linus Walleij wrote:
> On Tue, Jul 5, 2016 at 3:40 PM, Alexandre TORGUE
> <alexandre.torgue@st.com> wrote:
>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>
> The patch was a bit liberal with newlines so I cut some whitespace
> while applying.

Sorry for that and thanks for modifications.

Regards,

Alex

[toc] | [prev] | [next] | [standalone]

#1437110 — Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-07-05 17:10 +0200
SubjectRe: [PATCH 2/3] pinctrl: Add STM32F746 MCU support
Message-ID<rRA93-4vb-17@gated-at.bofh.it>
In reply to#1437030
On Tue, Jul 5, 2016 at 3:40 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>
> This patch which adds STM32F746 pinctrl and GPIO support, relies on the
> generic STM32 pinctrl driver.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Waiting for a new version of this patch addressing Mr. Gortmaker's comments.

I have applied the bindings in patch 1 & 3, you need not resend those.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web