Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1436931 > unrolled thread

[PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out

Started byLv Zheng <lv.zheng@intel.com>
First post2016-07-05 13:20 +0200
Last post2016-07-06 03:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out Lv Zheng <lv.zheng@intel.com> - 2016-07-05 13:20 +0200
    Re: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA  error logs out "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-06 01:50 +0200
      RE: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA  error logs out "Zheng, Lv" <lv.zheng@intel.com> - 2016-07-06 03:50 +0200

#1436931 — [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out

FromLv Zheng <lv.zheng@intel.com>
Date2016-07-05 13:20 +0200
Subject[PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out
Message-ID<rRwyt-24B-11@gated-at.bofh.it>
Sometimes, we need to disable ACPICA error logs to leave only ACPICA
debug logs enabled for debugging purpose. This is useful when ACPICA error
logs become a flood.

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=114201
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/Kconfig            |    7 +++++++
 include/acpi/platform/aclinux.h |    4 ++++
 2 files changed, 11 insertions(+)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 04af18f..939d235 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -324,6 +324,13 @@ config ACPI_TABLE_UPGRADE
 	  initrd, therefore it's safe to say Y.
 	  See Documentation/acpi/initrd_table_override.txt for details
 
+config ACPI_NO_ERROR_MESSAGES
+	bool "Disable error messages"
+	default n
+	help
+	  The ACPI subsystem can produce error messages. Saying Y disables
+	  this output.
+
 config ACPI_DEBUG
 	bool "Debug Statements"
 	default n
diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
index 93b61b1..ed27b52 100644
--- a/include/acpi/platform/aclinux.h
+++ b/include/acpi/platform/aclinux.h
@@ -77,6 +77,10 @@
 #define ACPI_MUTEX_DEBUG
 #endif
 
+#ifdef CONFIG_ACPI_NO_ERROR_MESSAGES
+#define ACPI_NO_ERROR_MESSAGES
+#endif
+
 #include <linux/string.h>
 #include <linux/kernel.h>
 #include <linux/ctype.h>
-- 
1.7.10

[toc] | [next] | [standalone]


#1437333 — Re: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out

From"Rafael J. Wysocki" <rafael@kernel.org>
Date2016-07-06 01:50 +0200
SubjectRe: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out
Message-ID<rRIgh-1ju-5@gated-at.bofh.it>
In reply to#1436931
On Tue, Jul 5, 2016 at 1:18 PM, Lv Zheng <lv.zheng@intel.com> wrote:
> Sometimes, we need to disable ACPICA error logs to leave only ACPICA
> debug logs enabled for debugging purpose. This is useful when ACPICA error
> logs become a flood.
>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=114201
> Signed-off-by: Lv Zheng <lv.zheng@intel.com>

I seem to remember seeing this change once before and ISTR I said I
wouldn't apply it then.

Why would I say something different this time?

> ---
>  drivers/acpi/Kconfig            |    7 +++++++
>  include/acpi/platform/aclinux.h |    4 ++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 04af18f..939d235 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -324,6 +324,13 @@ config ACPI_TABLE_UPGRADE
>           initrd, therefore it's safe to say Y.
>           See Documentation/acpi/initrd_table_override.txt for details
>
> +config ACPI_NO_ERROR_MESSAGES
> +       bool "Disable error messages"
> +       default n
> +       help
> +         The ACPI subsystem can produce error messages. Saying Y disables
> +         this output.
> +
>  config ACPI_DEBUG
>         bool "Debug Statements"
>         default n
> diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
> index 93b61b1..ed27b52 100644
> --- a/include/acpi/platform/aclinux.h
> +++ b/include/acpi/platform/aclinux.h
> @@ -77,6 +77,10 @@
>  #define ACPI_MUTEX_DEBUG
>  #endif
>
> +#ifdef CONFIG_ACPI_NO_ERROR_MESSAGES
> +#define ACPI_NO_ERROR_MESSAGES
> +#endif
> +
>  #include <linux/string.h>
>  #include <linux/kernel.h>
>  #include <linux/ctype.h>
> --

[toc] | [prev] | [next] | [standalone]


#1437358 — RE: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out

From"Zheng, Lv" <lv.zheng@intel.com>
Date2016-07-06 03:50 +0200
SubjectRE: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out
Message-ID<rRK8p-2B6-1@gated-at.bofh.it>
In reply to#1437333
Hi, Rafael

> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
> owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> Subject: Re: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA
> error logs out
> 
> On Tue, Jul 5, 2016 at 1:18 PM, Lv Zheng <lv.zheng@intel.com> wrote:
> > Sometimes, we need to disable ACPICA error logs to leave only ACPICA
> > debug logs enabled for debugging purpose. This is useful when ACPICA
> error
> > logs become a flood.
> >
> > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=114201
> > Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> 
> I seem to remember seeing this change once before and ISTR I said I
> wouldn't apply it then.
> 
> Why would I say something different this time?
[Lv Zheng] 
I missed that.
Now that I deleted this patch from my local queue.

Thanks and best regards
-Lv

> 
> > ---
> >  drivers/acpi/Kconfig            |    7 +++++++
> >  include/acpi/platform/aclinux.h |    4 ++++
> >  2 files changed, 11 insertions(+)
> >
> > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> > index 04af18f..939d235 100644
> > --- a/drivers/acpi/Kconfig
> > +++ b/drivers/acpi/Kconfig
> > @@ -324,6 +324,13 @@ config ACPI_TABLE_UPGRADE
> >           initrd, therefore it's safe to say Y.
> >           See Documentation/acpi/initrd_table_override.txt for details
> >
> > +config ACPI_NO_ERROR_MESSAGES
> > +       bool "Disable error messages"
> > +       default n
> > +       help
> > +         The ACPI subsystem can produce error messages. Saying Y disables
> > +         this output.
> > +
> >  config ACPI_DEBUG
> >         bool "Debug Statements"
> >         default n
> > diff --git a/include/acpi/platform/aclinux.h
> b/include/acpi/platform/aclinux.h
> > index 93b61b1..ed27b52 100644
> > --- a/include/acpi/platform/aclinux.h
> > +++ b/include/acpi/platform/aclinux.h
> > @@ -77,6 +77,10 @@
> >  #define ACPI_MUTEX_DEBUG
> >  #endif
> >
> > +#ifdef CONFIG_ACPI_NO_ERROR_MESSAGES
> > +#define ACPI_NO_ERROR_MESSAGES
> > +#endif
> > +
> >  #include <linux/string.h>
> >  #include <linux/kernel.h>
> >  #include <linux/ctype.h>
> > --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web