Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1436751 > unrolled thread

RE: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

Started byDexuan Cui <decui@microsoft.com>
First post2016-07-05 06:40 +0200
Last post2016-07-05 09:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  RE: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets Dexuan Cui <decui@microsoft.com> - 2016-07-05 06:40 +0200
    Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets David Miller <davem@davemloft.net> - 2016-07-05 08:30 +0200
      RE: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets Dexuan Cui <decui@microsoft.com> - 2016-07-05 08:50 +0200
        Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets David Miller <davem@davemloft.net> - 2016-07-05 09:00 +0200

#1436751 — RE: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

FromDexuan Cui <decui@microsoft.com>
Date2016-07-05 06:40 +0200
SubjectRE: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
Message-ID<rRqjo-6tZ-11@gated-at.bofh.it>
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Dexuan Cui
> Sent: Thursday, June 30, 2016 23:59
> diff --git a/include/linux/socket.h b/include/linux/socket.h
> index b5cc5a6..0b68b58 100644
> --- a/include/linux/socket.h
> +++ b/include/linux/socket.h
> @@ -202,8 +202,9 @@ struct ucred {
>  #define AF_VSOCK	40	/* vSockets			*/
>  #define AF_KCM		41	/* Kernel Connection Multiplexor*/
>  #define AF_QIPCRTR	42	/* Qualcomm IPC Router          */
> +#define AF_HYPERV	43	/* Hyper-V Sockets              */
> 
> -#define AF_MAX		43	/* For now.. */
> +#define AF_MAX		44	/* For now.. */

Hi David,
Not sure if you had a chance to review this version.
Now I have a question: may I split the include/linux/socket.h change
and ask you to pre-allocate the number for AF_HYPERV to allow
backporting of Hyper-V Sockets to distro kernels, and to make sure that
applications using the socket type will work with the backport as well
as the upstream kernel?

Thanks,
-- Dexuan

[toc] | [next] | [standalone]


#1436788

FromDavid Miller <davem@davemloft.net>
Date2016-07-05 08:30 +0200
Message-ID<rRs1P-7yT-5@gated-at.bofh.it>
In reply to#1436751
From: Dexuan Cui <decui@microsoft.com>
Date: Tue, 5 Jul 2016 01:58:31 +0000

> Not sure if you had a chance to review this version.

Why me?

Other people have to review this too.

> Now I have a question: may I split the include/linux/socket.h change
> and ask you to pre-allocate the number for AF_HYPERV to allow
> backporting of Hyper-V Sockets to distro kernels, and to make sure
> that applications using the socket type will work with the backport
> as well as the upstream kernel?

Sorry, I'm not going to do this.

You cannot commit anything in userspace to this value anywhere
until it is accepted upstream.

[toc] | [prev] | [next] | [standalone]


#1436799

FromDexuan Cui <decui@microsoft.com>
Date2016-07-05 08:50 +0200
Message-ID<rRslb-7Fk-1@gated-at.bofh.it>
In reply to#1436788
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, July 5, 2016 14:27
> To: Dexuan Cui <decui@microsoft.com>
> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
> 
> From: Dexuan Cui <decui@microsoft.com>
> Date: Tue, 5 Jul 2016 01:58:31 +0000
> 
> > Not sure if you had a chance to review this version.
> 
> Why me?
I just think you're the most responsive reviewer. :-)

> Other people have to review this too.
Sure. Let me try to ask more people to review this.
 
> > Now I have a question: may I split the include/linux/socket.h change
> > and ask you to pre-allocate the number for AF_HYPERV to allow
> > backporting of Hyper-V Sockets to distro kernels, and to make sure
> > that applications using the socket type will work with the backport
> > as well as the upstream kernel?
> 
> Sorry, I'm not going to do this.
> 
> You cannot commit anything in userspace to this value anywhere
> until it is accepted upstream.
Got it. Thanks for the explanation! 

Thanks,
-- Dexuan

[toc] | [prev] | [next] | [standalone]


#1436801

FromDavid Miller <davem@davemloft.net>
Date2016-07-05 09:00 +0200
Message-ID<rRsuR-7IG-1@gated-at.bofh.it>
In reply to#1436799
From: Dexuan Cui <decui@microsoft.com>
Date: Tue, 5 Jul 2016 06:46:24 +0000

>> From: David Miller [mailto:davem@davemloft.net]
>> Sent: Tuesday, July 5, 2016 14:27
>> To: Dexuan Cui <decui@microsoft.com>
>> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
>> 
>> From: Dexuan Cui <decui@microsoft.com>
>> Date: Tue, 5 Jul 2016 01:58:31 +0000
>> 
>> > Not sure if you had a chance to review this version.
>> 
>> Why me?
> I just think you're the most responsive reviewer. :-)

I'm the only reviewer, and that's a problem and simply unacceptable.

Nobody other than me is reviewing this code, and I'm not applying
these changes while that is the case.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web