Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436192 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-07-04 17:10 +0200 |
| Last post | 2016-07-05 08:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-07-04 17:10 +0200
Re: [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning Takashi Iwai <tiwai@suse.de> - 2016-07-05 08:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-04 17:10 +0200 |
| Subject | [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning |
| Message-ID | <rRdFw-7cY-33@gated-at.bofh.it> |
The awacs sound driver produces a false-positive warning in ppc64_defconfig: sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] I haven't come up with a good way to rewrite the code to avoid the warning, so here is a bad one: I initialize the variable before the conditionall initialization so gcc no longer has to worry about it. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- sound/ppc/awacs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/ppc/awacs.c b/sound/ppc/awacs.c index 09da7b52bc2e..1468e4b7bf93 100644 --- a/sound/ppc/awacs.c +++ b/sound/ppc/awacs.c @@ -991,6 +991,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip) if (err < 0) return err; } + master_vol = NULL; if (pm7500) err = build_mixers(chip, ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500), -- 2.9.0
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2016-07-05 08:40 +0200 |
| Message-ID | <rRsbv-7C5-17@gated-at.bofh.it> |
| In reply to | #1436192 |
On Mon, 04 Jul 2016 17:07:45 +0200, Arnd Bergmann wrote: > > The awacs sound driver produces a false-positive warning in ppc64_defconfig: > > sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': > include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] > > I haven't come up with a good way to rewrite the code to avoid the > warning, so here is a bad one: I initialize the variable before > the conditionall initialization so gcc no longer has to worry about > it. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web