Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436488 > unrolled thread

[PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

Back to article view | Back to linux.kernel

Contents

  [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-07-04 15:10 +0200
    Re: [PATCH] ASOC: Atmel: ClassD: Simplify use of  devm_ioremap_resource Mark Brown <broonie@kernel.org> - 2016-07-04 16:20 +0200
      Re: [PATCH] ASOC: Atmel: ClassD: Simplify use of  devm_ioremap_resource Julia Lawall <julia.lawall@lip6.fr> - 2016-07-04 17:00 +0200

#1436488 — [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 sound/soc/atmel/atmel-classd.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
index 6107de9..6d9b8b4 100644
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -593,11 +593,6 @@ static int atmel_classd_probe(struct platform_device *pdev)
 	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		dev_err(dev, "no memory resource\n");
-		return -ENXIO;
-	}
-
 	io_base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(io_base)) {
 		ret =  PTR_ERR(io_base);
-- 
1.9.1

[toc] | [next] | [standalone]

#1436541 — Re: [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jul 04, 2016 at 06:33:52PM +0530, Amitoj Kaur Chawla wrote:
> Remove unneeded error handling on the result of a call to
> platform_get_resource when the value is passed to
> devm_ioremap_resource.

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.

[toc] | [prev] | [next] | [standalone]

#1436577 — Re: [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

On Mon, 4 Jul 2016, Mark Brown wrote:

> On Mon, Jul 04, 2016 at 06:33:52PM +0530, Amitoj Kaur Chawla wrote:
> > Remove unneeded error handling on the result of a call to
> > platform_get_resource when the value is passed to
> > devm_ioremap_resource.
>
> Please use subject lines matching the style for the subsystem.  This
> makes it easier for people to identify relevant patches.

The point is that ASOC should be ASoC?  Ther aren't many patches on this
file, and two of the three have the same subject line as the above, but
with ASoC rather than ASOC.

thanks,
julia

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web