Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436854 > unrolled thread
| Started by | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| First post | 2016-07-05 11:10 +0200 |
| Last post | 2016-07-06 19:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] libnvdimm: initialize struct blk_integrity with 0 Johannes Thumshirn <jthumshirn@suse.de> - 2016-07-05 11:10 +0200
Re: [PATCH] libnvdimm: initialize struct blk_integrity with 0 Dan Williams <dan.j.williams@intel.com> - 2016-07-06 19:40 +0200
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2016-07-05 11:10 +0200 |
| Subject | Re: [PATCH] libnvdimm: initialize struct blk_integrity with 0 |
| Message-ID | <rRuwF-MJ-5@gated-at.bofh.it> |
On Thu, Jun 23, 2016 at 11:52:04AM +0200, Johannes Thumshirn wrote: > Initialize struct blk_integrity with 0 as blk_integrity_register() takes the > then unitialized struct blk_integrity::flags and ORs it to the resulting block > integrity structure. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > --- > drivers/nvdimm/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c > index be89764..32e4fe2 100644 > --- a/drivers/nvdimm/core.c > +++ b/drivers/nvdimm/core.c > @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size) > if (meta_size == 0) > return 0; > > - bi.profile = NULL; > + memset(&bi, 0, sizeof(bi)); > + > bi.tuple_size = meta_size; > bi.tag_size = meta_size; > > -- > 2.8.4 > Dan, have you seen this one? I've found it in patchwork but didn't get a mail on the list either. Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [next] | [standalone]
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2016-07-06 19:40 +0200 |
| Message-ID | <rRYXM-3I6-11@gated-at.bofh.it> |
| In reply to | #1436854 |
On Tue, Jul 5, 2016 at 2:02 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote: > On Thu, Jun 23, 2016 at 11:52:04AM +0200, Johannes Thumshirn wrote: >> Initialize struct blk_integrity with 0 as blk_integrity_register() takes the >> then unitialized struct blk_integrity::flags and ORs it to the resulting block >> integrity structure. >> >> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> >> --- >> drivers/nvdimm/core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c >> index be89764..32e4fe2 100644 >> --- a/drivers/nvdimm/core.c >> +++ b/drivers/nvdimm/core.c >> @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size) >> if (meta_size == 0) >> return 0; >> >> - bi.profile = NULL; >> + memset(&bi, 0, sizeof(bi)); >> + >> bi.tuple_size = meta_size; >> bi.tag_size = meta_size; >> >> -- >> 2.8.4 >> > > Dan, > > have you seen this one? I've found it in patchwork but didn't get a mail on > the list either. Thanks for the nudge, I missed this. Applied now.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web