Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436884 > unrolled thread

[PATCH] arm64: dts: Fix rtc by providing rtc_src clock

Back to article view | Back to linux.kernel

Contents

  [PATCH] arm64: dts: Fix rtc by providing rtc_src clock Alim Akhtar <alim.akhtar@samsung.com> - 2016-07-05 12:10 +0200
    Re: [PATCH] arm64: dts: Fix rtc by providing rtc_src clock Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-05 15:10 +0200
    Re: [PATCH] arm64: dts: Fix rtc by providing rtc_src clock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-06 08:30 +0200

#1436884 — [PATCH] arm64: dts: Fix rtc by providing rtc_src clock

Add rtc source clock as exynos7 needs source (32.768KHz) clock
for rtc block. Without this currently rtc driver probe is broken
on this SoC, thats because rtc-s3c driver expect rtc_src clock to
be provided for _s3c6410-rtc_ type rtc controllers.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index 03f9cf6..7f48cf0 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -12,6 +12,7 @@
 /dts-v1/;
 #include "exynos7.dtsi"
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/clock/samsung,s2mps11.h>
 
 / {
 	model = "Samsung Exynos7 Espresso board based on EXYNOS7";
@@ -44,6 +45,8 @@
 
 &rtc {
 	status = "okay";
+	clocks = <&clock_ccore PCLK_RTC>, <&s2mps15_osc S2MPS11_CLK_AP>;
+	clock-names = "rtc", "rtc_src";
 };
 
 &watchdog {
-- 
1.7.10.4

[toc] | [next] | [standalone]

#1436976

Hello Alim,

On 07/05/2016 06:05 AM, Alim Akhtar wrote:
> Add rtc source clock as exynos7 needs source (32.768KHz) clock
> for rtc block. Without this currently rtc driver probe is broken
> on this SoC, thats because rtc-s3c driver expect rtc_src clock to
> be provided for _s3c6410-rtc_ type rtc controllers.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index 03f9cf6..7f48cf0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -12,6 +12,7 @@
>  /dts-v1/;
>  #include "exynos7.dtsi"
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/clock/samsung,s2mps11.h>
>  
>  / {
>  	model = "Samsung Exynos7 Espresso board based on EXYNOS7";
> @@ -44,6 +45,8 @@
>  
>  &rtc {
>  	status = "okay";
> +	clocks = <&clock_ccore PCLK_RTC>, <&s2mps15_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
>  };
>  
>  &watchdog {
> 

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1437478

On 07/05/2016 12:05 PM, Alim Akhtar wrote:
> Add rtc source clock as exynos7 needs source (32.768KHz) clock
> for rtc block. Without this currently rtc driver probe is broken
> on this SoC, thats because rtc-s3c driver expect rtc_src clock to
> be provided for _s3c6410-rtc_ type rtc controllers.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |    3 +++
>  1 file changed, 3 insertions(+)

Thanks, applied with adjusted message. I'll send it as a fix for v4.7.

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web